Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): add root cause for failing component-styles docs e2e tests #28760

Closed
wants to merge 1 commit into from
Closed

test(ivy): add root cause for failing component-styles docs e2e tests #28760

wants to merge 1 commit into from

Conversation

marclaval
Copy link
Contributor

3 tests were failing. One was because of #28664 which is now fixed.
The other 2 fail because of FW-1069: ngtsc does not support inline <style> and '

@marclaval marclaval requested a review from a team as a code owner February 15, 2019 15:41
@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Feb 15, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 15, 2019
kara
kara approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (global approval)

@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 15, 2019
@mhevery mhevery closed this in 3c7ce82 Feb 17, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marclaval @kara @googlebot