fix(ivy): incorrectly remapping certain properties that refer to inputs #28765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
changed the title
crisbeto
force-pushed
the
FW-1063/property-mapping
branch
from
1d15c94
to
72b47b7
Compare
crisbeto
added
action: review
kara
requested changes
Feb 19, 2019
kara
added
action: cleanup
crisbeto
force-pushed
the
FW-1063/property-mapping
branch
2 times, most recently
from
0fad6b8
to
6ed7120
Compare
|
@kara I've switched the tests over to |
crisbeto
added
action: review
kara
reviewed
Feb 19, 2019
packages/compiler-cli/test/compliance/r3_view_compiler_template_spec.ts
Outdated
Show resolved
Hide resolved
crisbeto
force-pushed
the
FW-1063/property-mapping
branch
from
6ed7120
to
a93eef3
Compare
kara
requested changes
Feb 19, 2019
There was a problem hiding this comment.
@crisbeto Just realized that this PR should fix a number of Material tests, but we're not actually removing anything from the blocklist. Can you remove the relevant tests?
|
Updated @kara. It also has two new bonus failures that are due to static queries. |
filipesilva
approved these changes
Feb 20, 2019
kara
approved these changes
Feb 20, 2019
crisbeto
force-pushed
the
FW-1063/property-mapping
branch
from
1f42206
to
2fa5e34
Compare
|
It's rebased @kara. |
This comment has been minimized.
This comment has been minimized.
crisbeto
force-pushed
the
FW-1063/property-mapping
branch
from
2fa5e34
to
3c90e61
Compare
|
CLAs look good, thanks! Googlers can find more info about SignCLA and this PR by following this link. |
alxhub
approved these changes
Feb 20, 2019
kara
removed
the
action: review
kara
added
action: merge
crisbeto
force-pushed
the
FW-1063/property-mapping
branch
from
3c90e61
to
980a879
Compare
During build time we remap particular property bindings, because their names don't match their attribute equivalents (e.g. the property for the `for` attribute is called `htmlFor`). This breaks down if the particular element has an input that has the same name, because the property gets mapped to something invalid. The following changes address the issue by mapping the name during runtime, because that's when directives are resolved and we know all of the inputs that are associated with a particular element.
crisbeto
force-pushed
the
FW-1063/property-mapping
branch
from
980a879
to
424407a
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During build time we remap particular property bindings, because their names don't match their attribute equivalents (e.g. the property for the
forattribute is calledhtmlFor). This breaks down if the particular element has an input that has the same name, because the property gets mapped to something invalid.The following changes address the issue by mapping the name during runtime, because that's when directives are resolved and we know all of the inputs that are associated with a particular element.