Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable bundle_dts for common package #28834

Closed
wants to merge 2 commits into from
Closed

build: enable bundle_dts for common package #28834

wants to merge 2 commits into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Feb 19, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 requested review from a team as code owners February 19, 2019 18:02
@alan-agius4 alan-agius4 requested review from a team as code owners February 19, 2019 19:15
@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Feb 20, 2019
@benlesh benlesh added the area: common Issues related to APIs in the @angular/common package label Feb 20, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 20, 2019
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 6, 2019
@alan-agius4
Copy link
Contributor Author

CARETAKER: this has been approved by @IgorMinar.

AndrewKushnir pushed a commit that referenced this pull request Mar 6, 2019
@alan-agius4 alan-agius4 deleted the dts_bundle_common branch March 6, 2019 19:03
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants