Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Vendor yarn into our repo #28839

Closed
wants to merge 3 commits into from
Closed

ci: Vendor yarn into our repo #28839

wants to merge 3 commits into from

Conversation

alexeagle
Copy link
Contributor

This avoids a dynamic dependency on fetching a package from the internet in our CI.
We have observed that this is not 100% reliable.

@alexeagle alexeagle requested a review from a team as a code owner February 19, 2019 21:16
@alexeagle
ci: Vendor yarn into our repo
b1dbd75 
This avoids a dynamic dependency on fetching a package from the internet in our CI.
We have observed that this is not 100% reliable.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Googlers can find more info about SignCLA and this PR by following this link.

@gkalpak gkalpak force-pushed the vendor_yarn branch 6 times, most recently from fa11800 to df66d51 Compare February 20, 2019 11:58
@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 20, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 20, 2019
@gkalpak gkalpak added this to In progress in dev-infra via automation Feb 20, 2019
@gkalpak gkalpak moved this from In progress to Needs review in dev-infra Feb 20, 2019
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 20, 2019
@gkalpak gkalpak moved this from Needs review to Reviewer approved in dev-infra Feb 20, 2019
@gkalpak
Copy link
Member

gkalpak commented Feb 20, 2019

merge-assistance: Both authors have signed CLAs.

alexeagle
alexeagle commented Feb 20, 2019
View reviewed changes
Copy link
Contributor Author

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@alexeagle alexeagle removed the cla: no label Feb 20, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Googlers can find more info about SignCLA and this PR by following this link.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Googlers can find more info about SignCLA and this PR by following this link.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Googlers can find more info about SignCLA and this PR by following this link.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Googlers can find more info about SignCLA and this PR by following this link.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Googlers can find more info about SignCLA and this PR by following this link.

IgorMinar pushed a commit that referenced this pull request Feb 20, 2019
@alexeagle @IgorMinar
ci: Vendor yarn into our repo (#28839)
9d0db2f 
This avoids a dynamic dependency on fetching a package from the internet in our CI.
We have observed that this is not 100% reliable.

PR Close #28839
IgorMinar pushed a commit that referenced this pull request Feb 20, 2019
@alexeagle @IgorMinar
build: use vendored yarn under Bazel (#28839)
48cabb4 
PR Close #28839
@IgorMinar IgorMinar closed this in 9cecb0b Feb 20, 2019
IgorMinar pushed a commit that referenced this pull request Feb 20, 2019
@alexeagle @IgorMinar
build: use vendored yarn under Bazel (#28839)
1832e0f 
PR Close #28839
dev-infra automation moved this from Reviewer approved to Done Feb 20, 2019
gkalpak added a commit to gkalpak/angular that referenced this pull request Feb 21, 2019
@gkalpak
ci: make yarn globally available and independent of $BASH_ENV
fc74c72 
Previously, our yarn (which overwrote the pre-installed yarn on the
docker image) was only available through `$BASH_ENV` (as an exported
function). This caused it to be undefined for commands executed in other
shells (e.g. via Node.js' `child_process.spawn()` unless explicitly
configuring it to run with `bash`).

This commit fixes this by making our yarn version available globally via
a symlink (`/usr/local/bin/yarn`).

(This was accidentally broken in angular#28839.)
@gkalpak gkalpak mentioned this pull request Feb 21, 2019
Closed
gkalpak added a commit to gkalpak/angular that referenced this pull request Feb 21, 2019
@gkalpak
ci: make yarn globally available and independent of $BASH_ENV
1fea98c 
Previously, our yarn (which overwrote the pre-installed yarn on the
docker image) was only available through `$BASH_ENV` (as an exported
function). This caused it to be undefined for commands executed in other
shells (e.g. via Node.js' `child_process.spawn()` unless explicitly
configuring it to run with `bash`).

This commit fixes this by making our yarn version available globally via
a symlink (`/usr/local/bin/yarn`).

(This was accidentally broken in angular#28839.)
gkalpak added a commit to gkalpak/angular that referenced this pull request Feb 21, 2019
@gkalpak
ci: make yarn globally available and independent of $BASH_ENV
1c9769e 
Previously, our yarn (which overwrote the pre-installed yarn on the
docker image) was only available through `$BASH_ENV` (as an exported
function). This caused it to be undefined for commands executed in other
shells (e.g. via Node.js' `child_process.spawn()` unless explicitly
configuring it to run with `bash`).

This commit fixes this by making our yarn version available globally via
a symlink (`/usr/local/bin/yarn`).

(This was accidentally broken in angular#28839.)
gkalpak added a commit to gkalpak/angular that referenced this pull request Feb 21, 2019
@gkalpak
ci: make yarn globally available and independent of $BASH_ENV
8f715ec 
Previously, our yarn (which overwrote the pre-installed yarn on the
docker image) was only available through `$BASH_ENV` (as an exported
function). This caused it to be undefined for commands executed in other
shells (e.g. via Node.js' `child_process.spawn()` unless explicitly
configuring it to run with `bash`).

This commit fixes this by making our yarn version available globally via
a symlink (`/usr/local/bin/yarn`).

(This was accidentally broken in angular#28839.)
benlesh pushed a commit that referenced this pull request Feb 21, 2019
@gkalpak @benlesh
ci: make yarn globally available and independent of $BASH_ENV (#28889)
3f2b51b 
Previously, our yarn (which overwrote the pre-installed yarn on the
docker image) was only available through `$BASH_ENV` (as an exported
function). This caused it to be undefined for commands executed in other
shells (e.g. via Node.js' `child_process.spawn()` unless explicitly
configuring it to run with `bash`).

This commit fixes this by making our yarn version available globally via
a symlink (`/usr/local/bin/yarn`).

(This was accidentally broken in #28839.)

PR Close #28889
benlesh pushed a commit that referenced this pull request Feb 21, 2019
@gkalpak @benlesh
ci: make yarn globally available and independent of $BASH_ENV (#28889)
2817764 
Previously, our yarn (which overwrote the pre-installed yarn on the
docker image) was only available through `$BASH_ENV` (as an exported
function). This caused it to be undefined for commands executed in other
shells (e.g. via Node.js' `child_process.spawn()` unless explicitly
configuring it to run with `bash`).

This commit fixes this by making our yarn version available globally via
a symlink (`/usr/local/bin/yarn`).

(This was accidentally broken in #28839.)

PR Close #28889
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
dev-infra
  
Done
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexeagle @googlebot @gkalpak @filipesilva