Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): ngOnChanges hooks should be inherited from grand-superclasses #28888

Closed
wants to merge 2 commits into from
Closed

fix(ivy): ngOnChanges hooks should be inherited from grand-superclasses #28888

wants to merge 2 commits into from

Conversation

marclaval
Copy link
Contributor

This fixes FW-1082

@marclaval marclaval requested a review from a team as a code owner February 21, 2019 15:43
@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Feb 21, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 21, 2019
kara
kara requested changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but this change should also have fixed a number of Material tests.

Can you remove the tests in the blocklist that reference FW-1082?

https://github.com/angular/angular/blob/master/tools/material-ci/angular_material_test_blocklist.js#L1008

@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 21, 2019
@marclaval marclaval requested a review from a team as a code owner February 22, 2019 08:30
@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 22, 2019
@marclaval
Copy link
Contributor Author

@kara @crisbeto I've updated the blocklist following the instructions, please take a look

crisbeto
crisbeto approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kara
kara approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating

@kara kara added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 22, 2019
@kara
Copy link
Contributor

kara commented Feb 22, 2019

presubmit

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Feb 22, 2019
@benlesh benlesh closed this in 9dac04f Feb 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benlesh benlesh benlesh approved these changes

@kara kara kara approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marclaval @kara @benlesh @crisbeto @googlebot