build(bazel): allow a user to control a subset of angularCompilerOption in their tsconfig file when using ng_module

[gregmagolan]

Unblocks #28689 which requires the use of

  "angularCompilerOptions": {
    "i18nInFile": "translations.xlf"
  }

[alan-agius4]

extends can be available at multiple levels.
See: https://github.com/bazelbuild/rules_typescript/pull/265/files#diff-8c2aa63f0643c2daf20032369cf0a48fR286 & https://github.com/bazelbuild/rules_typescript/pull/265/files#diff-052e72d7fea048c0c20120cdda7337bdR61

[ocombe]

yeah in my case with this code it gets: /home/ocombe/.cache/bazel/_bazel_ocombe/df516b31b5c55b244dfb17f03a952d3d/execroot/angular/packages/tsconfig-build.json but it doesn't read the local tsconfig file that I defined in my bundle test folder

[ocombe]

Can't you make a loop that gets all properties of userConfig? We wouldn't need to maintain this when we add new compiler config options. And worst case scenario it would set an option that wouldn't be used

[alexeagle]

there are some properties which bazel needs to control, I think flatModuleId is an example.

ngc-wrapped is planned to be deprecated with Ivy so we don't need to put that much care here about maintainability

[ocombe]

@benlesh I don't think it was ready for merge, @alan-agius4 seems to have a legitimate comment, and the PR doesn't seem to fix my issue (which was the goal)
it's probably not your fault since there was a merge label :(
I guess there should be a follow up PR then

[gregmagolan]

@benlesh I don't think it was ready for merge, @alan-agius4 seems to have a legitimate comment, and the PR doesn't seem to fix my issue (which was the goal)
it's probably not your fault since there was a merge label :(
I guess there should be a follow up PR then

@ocombe I tried the failure target with this change and it fixed it locally. Are you still failing on the same issue?

[eachirei]

Sorry to hop in, but couldn't this also include

{
    "skipTemplateCodegen": true,
    "strictMetadataEmit": true,
    "fullTemplateTypeCheck": true
  }

I got some issues when building my project regarding

Error during template compile of 'AppModule'
  Function calls are not supported in decorators but 'StoreModule' was called.

and I understand that these options could fix that issue.

[gregmagolan]

@eachirei fullTemplateTypeCheck should default to true (you can also control that one with the type_check attribute on ng_module. The other two may be controllable under Bazel but I'm not sure of the implications of controlling metadata emit under Bazel which is why I left them out from the PR.

Have you looked at #23609?

[eachirei]

I'll give it another shot and try the method described in latest comment on that issue.

[eachirei]

Thing is the modules that are causing this problem are from external libraries, so I'll try to wrap them up with that method. I do not know the real cause of this, but I don't think this approach is feasible though.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}