New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update ivy opt-in flag #29010
docs: update ivy opt-in flag #29010
Conversation
You can preview 0c98cdd at https://pr29010-0c98cdd.ngbuilds.io/. |
This file gets matched for Igor only as a reviewer. According to the codeowners file this is a bug:
It looks like each guide is currently assigned to specific groups. So I guess this guide should also be assigned to some specific group. @IgorMinar I was told you set up this list yourself. Who should be the codeowner for this guide? |
BTW, I have a PR updating CODEOWNERS with missing guides etc: #28597 |
FYI, I've added |
Followup to angular#28569 (comment) and angular/angular-cli#13773. Note: this flag will only work on `@angular/cli@8.0.0-beta.3` (currently unreleased) and above.
0c98cdd
to
eaeb179
Compare
@gkalpak thanks, I rebased now and it should request a review from that group. |
Hm, no.... it didn't reset the needed reviews... :/ |
You can preview eaeb179 at https://pr29010-eaeb179.ngbuilds.io/. |
Caretaker assist: this is just a trivial correction to a CLI flag, doesn't need the listed reviews (and we are having problems with Codeowners on this one) |
@filipesilva, the PR is not merged yet, so the changes will not take effect until it is 😁 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Followup to #28569 (comment) and angular/angular-cli#13773.
Note: this flag will only work on
@angular/cli@8.0.0-beta.3
(currently unreleased) and above.Does this PR introduce a breaking change?
Other information