Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move doc from Routes type to Route interface #29012

Closed
wants to merge 3 commits into from
Closed

Move doc from Routes type to Route interface #29012

wants to merge 3 commits into from

Conversation

jbogarthyde
Copy link
Contributor

@jbogarthyde jbogarthyde commented Feb 27, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Moves the comprehensive doc that is shoe-horned into the collection Type Alias (https://angular.io/api/router/Routes) into the proper place for the collected object, the Route interface (https://angular.io/api/router/Route), so that it can formatted correctly and can be inspected for completeness and accuracy.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jbogarthyde jbogarthyde requested a review from a team as a code owner February 27, 2019 20:51
@ngbot ngbot bot added this to the needsTriage milestone Feb 27, 2019
@mary-poppins
Copy link

You can preview c197bb6 at https://pr29012-c197bb6.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 204eb88 at https://pr29012-204eb88.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4c8e09e at https://pr29012-4c8e09e.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 144cb5a at https://pr29012-144cb5a.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 5f1bff9 at https://pr29012-5f1bff9.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6c504a5 at https://pr29012-6c504a5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f9a482a at https://pr29012-f9a482a.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 49cd4ce at https://pr29012-49cd4ce.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 0e9f9f4 at https://pr29012-0e9f9f4.ngbuilds.io/.

@mary-poppins
Copy link

You can preview ed296d8 at https://pr29012-ed296d8.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 2560999 at https://pr29012-2560999.ngbuilds.io/.

@jbogarthyde
Copy link
Contributor Author

@jasonaden Please check and approve - thanks, jb

@mary-poppins
Copy link

You can preview 2164664 at https://pr29012-2164664.ngbuilds.io/.

jasonaden
jasonaden suggested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@jasonaden jasonaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this doc, the link for ROUTES no longer works.

packages/router/src/config.ts Outdated Show resolved Hide resolved
packages/router/src/config.ts Outdated Show resolved Hide resolved
packages/router/src/config.ts Outdated Show resolved Hide resolved
packages/router/src/config.ts Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 563f3d7 at https://pr29012-563f3d7.ngbuilds.io/.

@jbogarthyde jbogarthyde removed the request for review from jenniferfell March 7, 2019 22:44
@jbogarthyde jbogarthyde added the action: merge The PR is ready for merge by the caretaker label Mar 7, 2019
@kara kara closed this in 22c71b6 Mar 7, 2019
kara pushed a commit that referenced this pull request Mar 7, 2019
@jbogarthyde @kara
docs: add publicapi flag (#29012)
b14df41 
PR Close #29012
kara pushed a commit that referenced this pull request Mar 7, 2019
@jbogarthyde @kara
docs: clarify intro and examples (#29012)
aa6db0d 
PR Close #29012
kara pushed a commit that referenced this pull request Mar 7, 2019
@jbogarthyde @kara
docs: route interface and types doc example (#29012)
535ff05 
PR Close #29012
kara pushed a commit that referenced this pull request Mar 7, 2019
@jbogarthyde @kara
docs: add publicapi flag (#29012)
9417086 
PR Close #29012
kara pushed a commit that referenced this pull request Mar 7, 2019
@jbogarthyde @kara
docs: clarify intro and examples (#29012)
190330a 
PR Close #29012
@jbogarthyde jbogarthyde deleted the jb-apidoc-routes branch March 11, 2019 17:06
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@jbogarthyde @wKoza
docs: route interface and types doc example (angular#29012)
6a4bc16 
PR Close angular#29012
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@jbogarthyde @wKoza
docs: add publicapi flag (angular#29012)
d7ae3f7 
PR Close angular#29012
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@jbogarthyde @wKoza
docs: clarify intro and examples (angular#29012)
bb8741f 
PR Close angular#29012
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin left review comments

@jasonaden jasonaden jasonaden approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: router cla: yes effort2: days target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbogarthyde @mary-poppins @petebacondarwin @jasonaden @googlebot