Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): support property values changed in ngOnChanges (forward rre… #29054

Closed
wants to merge 4 commits into from
Closed

fix(ivy): support property values changed in ngOnChanges (forward rre… #29054

wants to merge 4 commits into from

Conversation

marclaval
Copy link
Contributor

…f case)

This fixes FW-1051

@marclaval marclaval requested review from IgorMinar and a team as code owners March 1, 2019 13:41
@marclaval
Copy link
Contributor Author

Some comments about this PR:

  • I've kept the flushHooksUpTo name for the instruction. It could be renamed to select.
  • We don't need to generate flushHooksUpTo(0)
  • The logic to execute hooks is becoming complex, I've tried to explain it through documentation and by renaming a few things here and there (for consistency).
  • In HookData, the negative index trick was already used to flag init hooks. I've used this NOOP token instead, but the same could be achieved with a bit flag.
  • I'd be happy to get some suggestions for better names

@marclaval marclaval requested a review from a team as a code owner March 1, 2019 14:03
@marclaval marclaval added state: WIP target: major This PR is targeted for the next major release comp: ivy labels Mar 1, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 1, 2019
@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Mar 1, 2019
kara
kara requested changes Mar 2, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! Some ideas below

packages/core/test/acceptance/exports_spec.ts Show resolved Hide resolved
packages/core/src/render3/hooks.ts Outdated Show resolved Hide resolved
packages/core/src/render3/interfaces/view.ts Show resolved Hide resolved
packages/core/src/render3/hooks.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions.ts Outdated Show resolved Hide resolved
packages/core/src/render3/hooks.ts Outdated Show resolved Hide resolved
packages/core/src/render3/interfaces/view.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions.ts Outdated Show resolved Hide resolved
packages/core/src/render3/hooks.ts Outdated Show resolved Hide resolved
packages/core/src/render3/hooks.ts Outdated Show resolved Hide resolved
@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 2, 2019
@marclaval marclaval force-pushed the localRefOfDir branch 3 times, most recently from 76a98ad to 616be28 Compare March 4, 2019 17:53
@marclaval marclaval removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 4, 2019
@marclaval
Copy link
Contributor Author

@kara thanks for all your suggestions, I've updated the PR accordingly

kara
kara reviewed Mar 4, 2019
View reviewed changes
packages/core/src/render3/interfaces/view.ts Outdated Show resolved Hide resolved
packages/core/src/render3/interfaces/view.ts Outdated Show resolved Hide resolved
packages/core/src/render3/hooks.ts Outdated Show resolved Hide resolved
packages/core/src/render3/hooks.ts Show resolved Hide resolved
kara
kara approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 5, 2019
@kara
Copy link
Contributor

kara commented Mar 5, 2019 •
edited

presubmit

new presubmit

@kara
Copy link
Contributor

kara commented Mar 5, 2019 •
edited

@marclaval G3 is complaining that we have a circular dependency because state.ts and hooks.ts depend on each other. Seems like maybe we will need to pass in the index to registerPreOrderHooks after all. (I can patch this today if you're off for the night)

@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 5, 2019
@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 5, 2019
@kara
Copy link
Contributor

kara commented Mar 5, 2019

merge-assistance: global approval

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marclaval @kara @googlebot