test(ivy): remove ngComponentOutlet example with a lazy-loaded NgModule

[pkozlowski-opensource]

This PR removes one of the existing examples and the associated e2e test. This might sound like a terrible thing to do (why would one remove an example from documentation???) but I will argue that this example does more harm than good.

There are multiple levels of problems with the code being demonstrated and the test setup, let me explain it step by step:

• the primary problem is in the API of ngComponentOutlet - this directive takes component Type and NgModuleFactory as @Input()s. Normally the Type should be enough but in view engine it is not enough for lazy loaded modules. So NgModuleFactory was introduced to support components from lazy-loaded modules but this is wrong API - componentFactoryResolver should have been used instead as it would cover both regular and lazy-loaded modules;
• Type was used instead of componentFactoryResolver since dealing with componentFactoryResolver is less ergonomic as compared to simply using Type. But this limitation will go away in ivy so introducing componentFactoryResolver into ngComponentOutlet at this point would just confuse everyone;
• so we are stuck with NgModuleFactory before ivy is default but getting an instance of NgModuleFactory in practice is super-difficult for an end-user - one either need to lazy-load it or use a Compiler (as in the example being deleted). I don't think that we want to teach people usage of Compiler for lazy loaded modules so this is why I'm claiming that the current example does more harm than good (teaches Compiler instead of lazy loading).

With ivy all those workflows (lazy loading, dynamic component instantiation) will get dramatically simpler so there is no great value in building examples on broken APIs and overly complex workflows.

As such I'm proposing the following:

• pre-ivy - re-move the confusing example (this is done in this PR);
• post-ivy: depreciate ngComponentOutletNgModuleFactory !: NgModuleFactory<any>; input

[alfaproject]

You can probably deprecate in version 8 (now?), and then it will get removed in like version 10, right?

[kara]

LGTM (global approval)

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}