Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(language-service): clean up imports language-service and mis… #29097

Closed
wants to merge 1 commit into from

Conversation

wKoza
Copy link
Contributor

@wKoza wKoza commented Mar 4, 2019

…spellings in the public API

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

clean up imports language-service and misspellings wordin public API

Does this PR introduce a breaking change?

  • Yes
  • No

@wKoza wKoza requested a review from a team as a code owner March 4, 2019 14:51
@kyliau kyliau added the area: language-service Issues related to Angular's VS Code language service label Mar 4, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 4, 2019
@kyliau kyliau added the target: patch This PR is targeted for the next patch release label Mar 4, 2019
Copy link
Contributor

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat! Thank you.

@kyliau
Copy link
Contributor

kyliau commented Mar 4, 2019

Could you please rebase master to get CI green?

@wKoza wKoza force-pushed the clean_up_language_service branch from 9ef1ec7 to 2d15566 Compare March 4, 2019 18:34
@wKoza wKoza force-pushed the clean_up_language_service branch from 2d15566 to 3398fff Compare March 4, 2019 19:04
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2019
AndrewKushnir pushed a commit that referenced this pull request Mar 5, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants