Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(docs-infra): run cli docs examples concurrently #29103

Closed
wants to merge 2 commits into from
Closed

ci(docs-infra): run cli docs examples concurrently #29103

wants to merge 2 commits into from

Conversation

devversion
Copy link
Member

No description provided.

@devversion devversion force-pushed the ci/concurrent-aio-examples branch 6 times, most recently from bb80a41 to 676f721 Compare March 4, 2019 23:33
@devversion devversion added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 4, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 4, 2019
@devversion devversion marked this pull request as ready for review March 4, 2019 23:42
@devversion devversion requested review from a team as code owners March 4, 2019 23:42
@devversion
Copy link
Member Author

devversion commented Mar 4, 2019 •
edited

@IgorMinar @gkalpak I brought down the non-ivy docs example tests job to 3min and the Ivy docs examples to 4min.

This will be ultimately solved by Bazel anyway, but for now this is most likely even faster than with Bazel. so we have some good baseline and it helps with #28940 😁

gkalpak
gkalpak approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. LGTM otherwise 👍

aio/tools/examples/run-example-e2e.js Outdated Show resolved Hide resolved
aio/tools/examples/run-example-e2e.js Show resolved Hide resolved
aio/tools/examples/run-example-e2e.js Outdated Show resolved Hide resolved
aio/tools/examples/run-example-e2e.js Outdated Show resolved Hide resolved
@devversion
Copy link
Member Author

@gkalpak Addressed your feedback. thanks!

Note: This PR still needs approval from fw-core and fw-i18n

AndrewKushnir
AndrewKushnir approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from i18n side 👍

@gkalpak
Copy link
Member

gkalpak commented Mar 7, 2019

@AndrewKushnir, what about fw-core? 😁

@devversion
Copy link
Member Author

Yeah, still needs review from @angular/fw-core I think. Can someone please have a look?

kara
kara approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 12, 2019
@kara
Copy link
Contributor

kara commented Mar 12, 2019

caretaker note: merging to master branch since patch didn't apply cleanly. @devversion is creating a new PR for patch

@kara kara closed this in e20a29a Mar 12, 2019
kara pushed a commit that referenced this pull request Mar 12, 2019
@devversion @kara
ci(docs-infra): run cli docs examples concurrently (#29103)
4227126 
PR Close #29103
@devversion devversion mentioned this pull request Mar 12, 2019
Closed
@kara kara mentioned this pull request Mar 21, 2019
Closed
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@devversion @wKoza
build(docs-infra): support running cli docs examples concurrently (an…
fd279b4 
…gular#29103)

PR Close angular#29103
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@devversion @wKoza
ci(docs-infra): run cli docs examples concurrently (angular#29103)
1761536 
PR Close angular#29103
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@kara kara kara approved these changes

@gkalpak gkalpak gkalpak approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@devversion @gkalpak @kara @petebacondarwin @AndrewKushnir @IgorMinar @googlebot