fix(ivy): handle aliased Angular decorators #29195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the code didn't take into account the fact that decorators can be aliases while importing into a script. As a result, these decorators were not recognized by Angular and various failures happened because of that. Now we take aliases into account and resolve decorator name properly.
AndrewKushnir
added
type: bug/fix
action: review
alxhub
approved these changes
Mar 8, 2019
AndrewKushnir
added
action: presubmit
AndrewKushnir
added
action: merge
alfaproject
reviewed
Mar 9, 2019
| @@ -81,7 +81,7 @@ export class DecorationAnalyzer { | |||
| importGraph = new ImportGraph(this.moduleResolver); | |||
| cycleAnalyzer = new CycleAnalyzer(this.importGraph); | |||
| handlers: DecoratorHandler<any, any>[] = [ | |||
| new BaseDefDecoratorHandler(this.reflectionHost, this.evaluator), | |||
| new BaseDefDecoratorHandler(this.reflectionHost, this.evaluator, this.isCore), | |||
There was a problem hiding this comment.
gkalpak
reviewed
Mar 9, 2019
| @@ -153,10 +153,23 @@ export function isAngularCore(decorator: Decorator): boolean { | |||
| return decorator.import !== null && decorator.import.from === '@angular/core'; | |||
| } | |||
|
|
|||
| export function isAngularCoreReference(reference: Reference, symbolName: string) { | |||
| export function isAngularCoreReference(reference: Reference, symbolName: string): boolean { | |||
AndrewKushnir
removed
the
action: merge
gkalpak
added
the
action: review
alxhub
approved these changes
Mar 11, 2019
AndrewKushnir
added
action: merge
AndrewKushnir
added
action: merge
|
Caretaker: CI is green (including |
devversion
pushed a commit
to devversion/angular
that referenced
this pull request
Mar 12, 2019
Prior to this change the code didn't take into account the fact that decorators can be aliases while importing into a script. As a result, these decorators were not recognized by Angular and various failures happened because of that. Now we take aliases into account and resolve decorator name properly. PR Close angular#29195
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
Prior to this change the code didn't take into account the fact that decorators can be aliases while importing into a script. As a result, these decorators were not recognized by Angular and various failures happened because of that. Now we take aliases into account and resolve decorator name properly. PR Close angular#29195
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the code didn't take into account the fact that decorators can be aliases while importing into a script. As a result, these decorators were not recognized by Angular and various failures happened because of that. Now we take aliases into account and resolve decorator name properly.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?