Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): unable to inherit view queries into component from directive #29203

Closed
wants to merge 1 commit into from
Closed

fix(ivy): unable to inherit view queries into component from directive #29203

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 9, 2019

Fixes components not being able to inherit their view queries from a directive.

This PR resolves FW-1146.

@crisbeto crisbeto added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy labels Mar 9, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 9, 2019
@crisbeto crisbeto marked this pull request as ready for review March 9, 2019 13:57
@crisbeto crisbeto requested review from a team as code owners March 9, 2019 13:57
kara
kara approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sans typo and minor fixes

packages/compiler-cli/test/ngtsc/ngtsc_spec.ts Show resolved Hide resolved
packages/core/src/render3/jit/directive.ts Outdated Show resolved Hide resolved
packages/core/src/render3/interfaces/definition.ts Show resolved Hide resolved
packages/core/src/render3/definition.ts Outdated Show resolved Hide resolved
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 12, 2019
@kara
Copy link
Contributor

kara commented Mar 12, 2019

presubmit

@crisbeto
fix(ivy): unable to inherit view queries into component from directive
7b9ca36 
Fixes components not being able to inherit their view queries from a directive.

This PR resolves FW-1146.
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 13, 2019
@kara kara added target: major This PR is targeted for the next major release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 13, 2019
@kara
Copy link
Contributor

kara commented Mar 13, 2019

merge-assistance: Misko has global approval

@matsko matsko closed this in 0ffa2f2 Mar 13, 2019
gkalpak pushed a commit to gkalpak/angular that referenced this pull request Mar 14, 2019
@crisbeto @gkalpak
fix(ivy): unable to inherit view queries into component from directive (
1d65f16 
angular#29203)

Fixes components not being able to inherit their view queries from a directive.

This PR resolves FW-1146.

PR Close angular#29203
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@crisbeto @wKoza
fix(ivy): unable to inherit view queries into component from directive (
20c3333 
angular#29203)

Fixes components not being able to inherit their view queries from a directive.

This PR resolves FW-1146.

PR Close angular#29203
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @kara @mhevery @googlebot