Update to nodejs rules 0.27

[gregmagolan]

No description provided.

[gregmagolan]

Note: material-unit-tests failure has numerous failures that look like this

Firefox 63.0.0 (Linux 0.0.0) MatPaginator with the default internationalization provider should re-render when the i18n labels change FAILED
    Error: BrowserDynamicTestingModule has no @NgModule annotation in node_modules/systemjs/dist/system.js line 4 > eval (line 1564)
    TestBedRender3</TestBedRender3.prototype._compileNgModule@node_modules/@angular/core/bundles/core-testing.umd.js:1564:23
    calcTransitiveScopesFor/<@node_modules/@angular/core/bundles/core-testing.umd.js:1597:139
    transitiveScopesFor/<@node_modules/@angular/core/bundles/core.umd.js:21168:17

if @__PURE__ annotations are stripped out of the angular bundles (which happens by default with the update to rollup 1.3.1.

The platform-browser-dynamic-testing.umd.js Ivy bundle contains a number of __PURE__ annotations including one for BrowserDynamicTestingModule:

    var BrowserDynamicTestingModule = /** @class */ (function () {
        function BrowserDynamicTestingModule() {
        }
        BrowserDynamicTestingModule.ngModuleDef = i0.ɵdefineNgModule({ type: BrowserDynamicTestingModule, exports: [testing$1.BrowserTestingModule] });
        BrowserDynamicTestingModule.ngInjectorDef = i0.defineInjector({ factory: function BrowserDynamicTestingModule_Factory(t) { return new (t || BrowserDynamicTestingModule)(); }, providers: [
                { provide: testing.TestComponentRenderer, useClass: DOMTestComponentRenderer },
            ], imports: [[testing$1.BrowserTestingModule]] });
        return BrowserDynamicTestingModule;
    }());
    /*@__PURE__*/ i0.ɵsetClassMetadata(BrowserDynamicTestingModule, [{
            type: i0.NgModule,
            args: [{
                    exports: [testing$1.BrowserTestingModule],
                    providers: [
                        { provide: testing.TestComponentRenderer, useClass: DOMTestComponentRenderer },
                    ]
                }]
        }], null, null);

There are also __PURE__ annotations in other Ivy bundles.

[gregmagolan]

For reference, rollup version was updated here bazelbuild/rules_nodejs#584 which brough in the @__PURE__ annotation tree shaking feature.

[alexeagle]

yeah seems like a bug for these annotations to be tree-shaken in the testing bundles? since many tests need them in JIT mode?

[filipesilva]

I don't think it's a rollup bug. I think libraries need to be run rollup with this option turned off, and applications need to run with it turned on.

[gregmagolan]

rollup needed an upgrade to fix test failures in the upgrade-phonecat-2-hybrid test. It seems like rollup 0.41.6 couldn't handle the angular bundles produced by rollup 1.3.1 (which is what ng_packager now uses since it shares the version with rollup_bundle).

[alexeagle]

Caretaker: has global approval

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}