build: user bazelrc should be able to overwrite existing flags #29279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the project `bazelrc` file imports a user bazelrc if present. This has been added in order to allow user-specific Bazel configuration settings when working within the Angular project. Since we currently import that user configuration before setting the project-specific settings, it's not possible for developers to overwrite given options (e.g. the `symlink_prefix`). Moving the import to the end of the file solves that problem.
devversion
added
area: build & ci
gkalpak
approved these changes
Mar 13, 2019
devversion
added
action: merge
kara
pushed a commit
that referenced
this pull request
Mar 13, 2019
Currently the project `bazelrc` file imports a user bazelrc if present. This has been added in order to allow user-specific Bazel configuration settings when working within the Angular project. Since we currently import that user configuration before setting the project-specific settings, it's not possible for developers to overwrite given options (e.g. the `symlink_prefix`). Moving the import to the end of the file solves that problem. PR Close #29279
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…ar#29279) Currently the project `bazelrc` file imports a user bazelrc if present. This has been added in order to allow user-specific Bazel configuration settings when working within the Angular project. Since we currently import that user configuration before setting the project-specific settings, it's not possible for developers to overwrite given options (e.g. the `symlink_prefix`). Moving the import to the end of the file solves that problem. PR Close angular#29279
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the project
bazelrcfile imports a user bazelrc if present. Thishas been added in order to allow user-specific Bazel configuration settings
when working within the Angular project. Since we currently import that
user configuration before setting the project-specific settings, it's not
possible for developers to overwrite given options (e.g. the
symlink_prefix).Moving the import to the end of the file solves that problem.