fix(ivy): avoid remote scoping if it's not actually required #29404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
reviewed
Mar 19, 2019
| @@ -3934,6 +3967,57 @@ export const Foo = Foo__PRE_R3__; | |||
| expect(jsContents).toContain('styles: ["h1[_ngcontent-%COMP%] {font-size: larger}"]'); | |||
| }); | |||
| }); | |||
|
|
|||
| xit('should not suck', () => { | |||
There was a problem hiding this comment.
Hahaha. That's my usual test description for reproducing bugs within the compiler's test suite.
alxhub
force-pushed
the
ngtsc-remote-scope
branch
3 times, most recently
from
2cac81f
to
15d606b
Compare
JoostK
reviewed
Mar 19, 2019
|
|
||
| // The BoundTarget knows which directives and pipes matched the template. | ||
| const usedDirectives = bound.getUsedDirectives(); | ||
| const usedPipes = bound.getUsedPipes().map(name => pipes.get(name) !); |
There was a problem hiding this comment.
This non-null assertion operator is actually a problem, I think. T3TargetBinder, or more specifically TemplateBinder:
angular/packages/compiler/src/render3/view/t2_binder.ts
Lines 444 to 447 in 5ad2097
tracks pipes just by name regardless of their definition. So, a missing pipe results in a miss here.
edit: aha, existing code. Still, looks error-prone to me.
There was a problem hiding this comment.
You're absolutely right. I'll file an issue to clean that up.
gkalpak
reviewed
Mar 20, 2019
| // any import which needs to be generated for the directive would create a cycle. | ||
| const cycleDetected = directives.some(dir => this._isCyclicImport(dir.expression, context)) || | ||
| Array.from(pipes.values()).some(pipe => this._isCyclicImport(pipe, context)); | ||
| // Next, the component template AST is bound using the R3TargetBinder. This produces an |
alxhub
added
action: merge
Currently, ngtsc decides to use remote scoping if the compilation of a component may create a cyclic import. This happens if there are two components in a scope (say, A and B) and A directly uses B. During compilation of B ngtsc will then note that if B were to use A, a cycle would be generated, and so it will opt to use remote scoping for B. ngtsc already uses the R3TargetBinder to correctly track the imports that are actually required, for future cycle tracking. This commit expands that usage to not trigger remote scoping unless B actually does consume A in its template.
alxhub
force-pushed
the
ngtsc-remote-scope
branch
from
15d606b
to
f846f03
Compare
alxhub
added
action: merge
|
I am the approver for compiler-cli. |
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…#29404) Currently, ngtsc decides to use remote scoping if the compilation of a component may create a cyclic import. This happens if there are two components in a scope (say, A and B) and A directly uses B. During compilation of B ngtsc will then note that if B were to use A, a cycle would be generated, and so it will opt to use remote scoping for B. ngtsc already uses the R3TargetBinder to correctly track the imports that are actually required, for future cycle tracking. This commit expands that usage to not trigger remote scoping unless B actually does consume A in its template. PR Close angular#29404
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ngtsc decides to use remote scoping if the compilation of a
component may create a cyclic import. This happens if there are two
components in a scope (say, A and B) and A directly uses B. During
compilation of B ngtsc will then note that if B were to use A, a cycle would
be generated, and so it will opt to use remote scoping for B.
ngtsc already uses the R3TargetBinder to correctly track the imports that
are actually required, for future cycle tracking. This commit expands that
usage to not trigger remote scoping unless B actually does consume A in its
template.