Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Luis Aviles to GDE resources #29405

Closed
wants to merge 1 commit into from

Conversation

luixaviles
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This adds Luis Aviles to the list of Angular GDEs on the Angular Docs page.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@luixaviles luixaviles requested a review from a team as a code owner March 19, 2019 20:41
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@luixaviles
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ngbot ngbot bot added this to the needsTriage milestone Mar 19, 2019
@brandonroberts brandonroberts added feature Issue that requests a new feature effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR docsarea: marketing labels Mar 20, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Mar 20, 2019
@brandonroberts brandonroberts self-assigned this Mar 20, 2019
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Mar 20, 2019
Copy link
Contributor

@StephenFluin StephenFluin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks fine, there's a couple unrelated whitespace changes that will likely conflict with other GDEs being added.

@matsko
Copy link
Contributor

matsko commented Mar 20, 2019

@luixaviles please rebase

matsko pushed a commit that referenced this pull request Mar 20, 2019
@matsko matsko closed this in afe3e72 Mar 20, 2019
@luixaviles
Copy link
Contributor Author

@matsko my branch is in sync now. Should I open a new PR?

@matsko
Copy link
Contributor

matsko commented Mar 22, 2019

@luixaviles no need ... I took care of it c75e16a

wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours feature Issue that requests a new feature risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants