Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix html tags in changelog #29411

Closed
wants to merge 1 commit into from
Closed

docs: fix html tags in changelog #29411

wants to merge 1 commit into from

Conversation

macjohnny
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

the tags are interpreted as html instead of being shown when viewing the changelog

Issue Number: N/A

What is the new behavior?

the tags are shown as code

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@macjohnny macjohnny requested a review from a team as a code owner March 20, 2019 06:40
@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: docs target: patch This PR is targeted for the next patch release labels Mar 20, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 20, 2019
gkalpak
gkalpak requested changes Mar 20, 2019
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!
Could you please change the commit message to docs: ...?

@macjohnny
Copy link
Contributor Author

@gkalpak I updated the commit message

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 20, 2019
@gkalpak gkalpak changed the title docs(changelog): fix html tags in changelog docs: fix html tags in changelog Mar 20, 2019
@macjohnny
Copy link
Contributor Author

macjohnny commented Mar 20, 2019 •
edited

@gkalpak the build error Error: The Angular Compiler requires TypeScript >=3.3.3333 and <3.4.0 but 3.1.6 was found instead. seems to be unrelated to this change
(https://circleci.com/gh/angular/angular/252446?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)

@gkalpak gkalpak added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 20, 2019
@gkalpak
Copy link
Member

gkalpak commented Mar 20, 2019 •
edited

merge-assistance: The Material tests failure is unrelated to this PR.

@macjohnny
Copy link
Contributor Author

@gkalpak all CI tests pass

@gkalpak gkalpak removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 20, 2019
@matsko
Copy link
Contributor

matsko commented Mar 20, 2019

@macjohnny please rebase.

@matsko matsko added target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release labels Mar 20, 2019
@matsko
Copy link
Contributor

matsko commented Mar 20, 2019

Also get rid of the 2nd commit (the merge one).

@matsko matsko removed the action: merge The PR is ready for merge by the caretaker label Mar 20, 2019
@macjohnny
Copy link
Contributor Author

@gkalpak @matsko I rebased the PR. now it has only one commit with the correct commit message, and the tests pass, so it should be good to go. sorry for the inconveniences

@matsko matsko added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 21, 2019
@matsko matsko closed this in 41737bb Mar 21, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@macjohnny @wKoza
docs: fix html tags in changelog (angular#29411)
0c13a39 
PR Close angular#29411
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@macjohnny @gkalpak @matsko @googlebot