Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): remove passing test from blocklist #29484

Closed
wants to merge 1 commit into from
Closed

test(ivy): remove passing test from blocklist #29484

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Removes the test that was fixed by angular/components#15555 from the blocklist.

@crisbeto
test(ivy): remove passing test from blocklist
7303c04 
Removes the test that was fixed by angular/components#15555 from the blocklist.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy labels Mar 22, 2019
@crisbeto crisbeto requested a review from a team as a code owner March 22, 2019 22:28
@ngbot ngbot bot added this to the needsTriage milestone Mar 22, 2019
kara
kara approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 22, 2019
@mhevery mhevery closed this in cfe6581 Mar 22, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@crisbeto @wKoza
test(ivy): remove passing test from blocklist (angular#29484)
efd32fd 
Removes the test that was fixed by angular/components#15555 from the blocklist.

PR Close angular#29484
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @kara @googlebot