Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): debug element should support components with ViewContainerRef #29534

Closed
wants to merge 3 commits into from
Closed

fix(ivy): debug element should support components with ViewContainerRef #29534

wants to merge 3 commits into from

Conversation

marclaval
Copy link
Contributor

Without the fix, the added test was throwing an exception:

Message:
    TypeError: Cannot read property 'type' of undefined
  Stack:
        at <Jasmine>
        at _queryNodeChildrenR3 (packages/core/src/debug/debug_node.ts:425:13)
        at _queryAllR3 (packages/core/src/debug/debug_node.ts:409:3)
        at DebugElement__POST_R3__.queryAll (packages/core/src/debug/debug_node.ts:374:5)
        at DebugElement__POST_R3__.query (packages/core/src/debug/debug_node.ts:368:26)
        at UserContext.<anonymous> (packages/core/test/debug/debug_node_spec.ts:643:42)

@marclaval marclaval requested a review from a team as a code owner March 27, 2019 09:50
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Mar 27, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 27, 2019
kara
kara approved these changes Mar 27, 2019
View reviewed changes
packages/core/src/debug/debug_node.ts Outdated Show resolved Hide resolved
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 27, 2019
@kara kara added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 27, 2019
@kara
Copy link
Contributor

kara commented Mar 27, 2019 •
edited

presubmit

new presubmit

@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer state: WIP and removed action: merge The PR is ready for merge by the caretaker labels Mar 28, 2019
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 28, 2019
@jasonaden jasonaden closed this in 50f7ab2 Mar 29, 2019
jasonaden pushed a commit that referenced this pull request Mar 29, 2019
@marclaval @jasonaden
fix(ivy): querying should be possible on any debug element (#29534)
303eae9 
PR Close #29534
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@marclaval @wKoza
fix(ivy): debug element should support components with ViewContainerR…
2ed3186 
…ef (angular#29534)

PR Close angular#29534
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@marclaval @wKoza
fix(ivy): querying should be possible on any debug element (angular#2…
83d423c 
…9534)

PR Close angular#29534
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marclaval @kara @mhevery @pkozlowski-opensource @googlebot