Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(compiler-cli): track visited source files in PartialEvaluator #29539

Closed
wants to merge 2 commits into from
Closed

refactor(compiler-cli): track visited source files in PartialEvaluator #29539

wants to merge 2 commits into from

Conversation

petebacondarwin
Copy link
Member

// FW-1194

@petebacondarwin petebacondarwin added state: WIP refactoring Issue that involves refactoring or code-cleanup area: core Issues related to the framework runtime comp: ivy labels Mar 27, 2019
@petebacondarwin petebacondarwin requested a review from a team as a code owner March 27, 2019 12:24
@ngbot ngbot bot modified the milestone: needsTriage Mar 27, 2019
alxhub
alxhub approved these changes Mar 28, 2019
View reviewed changes
packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts
@@ -231,6 +233,9 @@ export class StaticInterpreter {
}

private visitDeclaration(node: ts.Declaration, context: Context): ResolvedValue {
if (this.visitedFilesCb) {
this.visitedFilesCb(node.getSourceFile());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was easier than I expected.

I suppose this catches everything. We add the starting expression, plus the ts.SourceFile of any declaration we traverse while evaluating... I think that'll work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't think of any other scenarios (except for the annoying re-re-export situation) that we would miss.

@alxhub alxhub added the target: major This PR is targeted for the next major release label Mar 28, 2019
@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Mar 28, 2019
@ngbot
Copy link

ngbot bot commented Mar 28, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "google3" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jasonaden jasonaden closed this in 06859f1 Apr 1, 2019
jasonaden pushed a commit that referenced this pull request Apr 1, 2019
@petebacondarwin @jasonaden
style(compiler-cli): ensure FFR type is implemented correctly (#29539)
39345b6 
PR Close #29539
@petebacondarwin petebacondarwin deleted the FW-1194 branch April 1, 2019 19:02
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@petebacondarwin @wKoza
refactor(compiler-cli): track visited source files in PartialEvaluator (
ff5bffb 
angular#29539)

PR Close angular#29539
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@petebacondarwin @wKoza
style(compiler-cli): ensure FFR type is implemented correctly (angula…
13fe3e7 
…r#29539)

PR Close angular#29539
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petebacondarwin @alxhub @googlebot