Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move select instruction in front of relevant update instructions #29546

Closed
wants to merge 2 commits into from
Closed

Move select instruction in front of relevant update instructions #29546

wants to merge 2 commits into from

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented Mar 27, 2019 •
edited

@benlesh benlesh added state: blocked refactoring Issue that involves refactoring or code-cleanup area: core Issues related to the framework runtime target: major This PR is targeted for the next major release comp: ivy risk: low labels Mar 27, 2019
@benlesh benlesh requested review from a team as code owners March 27, 2019 16:33
@ngbot ngbot bot added this to the needsTriage milestone Mar 27, 2019
alxhub
alxhub approved these changes Mar 27, 2019
View reviewed changes
packages/compiler/src/render3/view/template.ts Outdated Show resolved Hide resolved
@benlesh benlesh mentioned this pull request Mar 27, 2019
Closed
@benlesh
Copy link
Contributor Author

benlesh commented Mar 27, 2019

presubmit

@benlesh benlesh added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 27, 2019
@mhevery mhevery closed this in 96b800c Mar 27, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@benlesh @wKoza
feat(ivy): select instruction now generated in front of all relevant …
f1e317d 
…instructions (angular#29546)

PR Close angular#29546
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes refactoring Issue that involves refactoring or code-cleanup risk: low target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benlesh @kara @alxhub @googlebot