Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ivy): remove duplicated flatten util #29547

Closed
wants to merge 1 commit into from
Closed

refactor(ivy): remove duplicated flatten util #29547

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

This commit removes code duplication where we had 2 versions of a
flatten utility. Moreover this change results in queries using
a non-recursive version of flatten which should result in a better
performance of query refresh operations.

@pkozlowski-opensource
refactor(ivy): remove duplicated flatten util
e5d9038 
This commit removes code duplication where we had 2 versions of a
`flatten` utility. Moreover this change results in queries using
a non-recursive version of `flatten` which should result in a better
performance of query refresh operations.
@pkozlowski-opensource pkozlowski-opensource added target: major This PR is targeted for the next major release comp: ivy labels Mar 27, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 27, 2019
@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 27, 2019
@mhevery
Copy link
Contributor

mhevery commented Mar 27, 2019

http://test/OCL:240597364:BASE:240597407:1553709377436:ec7999c5

kara
kara approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@kara kara added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 27, 2019
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review March 27, 2019 18:11
@kara kara removed the action: presubmit The PR is in need of a google3 presubmit label Mar 27, 2019
@mhevery mhevery closed this in dd69e4e Mar 27, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@pkozlowski-opensource @wKoza
refactor(ivy): remove duplicated flatten util (angular#29547)
6ccb092 
This commit removes code duplication where we had 2 versions of a
`flatten` utility. Moreover this change results in queries using
a non-recursive version of `flatten` which should result in a better
performance of query refresh operations.

PR Close angular#29547
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@benlesh benlesh benlesh approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pkozlowski-opensource @mhevery @benlesh @kara @googlebot