Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

@angular/bazel's schematics property should be project not name #29572

Closed
mgechev opened this issue Mar 28, 2019 · 2 comments
Closed

@angular/bazel's schematics property should be project not name #29572

mgechev opened this issue Mar 28, 2019 · 2 comments
Assignees
Labels
area: bazel Issues related to the published `@angular/bazel` build rules freq1: low type: bug/fix
Milestone

Comments

@mgechev
Copy link
Member

mgechev commented Mar 28, 2019

馃殌 feature request

Relevant Package

@angular/bazel

Description

When ng add @angular/bazel we need to specify the project with --name. This is not intuitive, especially if we omit it:

~/Projects/real-world-bazel master* ng add @angular/bazel
Skipping installation: Package already installed
Schematic input does not validate against the Schema: {}
Errors:

  Data path "" should have required property 'name'.

Describe the solution you'd like

Rename the option to --project or --project-name.

@mgechev mgechev added the area: bazel Issues related to the published `@angular/bazel` build rules label Mar 28, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 28, 2019
@kyliau kyliau self-assigned this Apr 18, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Apr 24, 2019
@kyliau
Copy link
Contributor

kyliau commented Apr 24, 2019

Should have been closed by #30074

Manually closing this.

@kyliau kyliau closed this as completed Apr 24, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: bazel Issues related to the published `@angular/bazel` build rules freq1: low type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants