Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ivy: Add propertyInterpolate instructions #29576

Closed
wants to merge 3 commits into from
Closed

Ivy: Add propertyInterpolate instructions #29576

wants to merge 3 commits into from

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented Mar 28, 2019

  • Adds all propertyInterpolate instructions outline in the design doc
  • Adds tests for all instructions
  • Does NOT add instruction generation to the compiler
  • Adds TODO to remind us to remove the tests once the compiler is updated and we can test with TestBed.
  • Does NOT add additional optimizations or rewrites to existing code. Current code paths are used. We can optimize these new instructions in another PR.

Blocked on #29557 which is blocked on #29513

@benlesh benlesh added feature Issue that requests a new feature state: blocked area: core Issues related to the framework runtime target: major This PR is targeted for the next major release comp: ivy risk: low labels Mar 28, 2019
@benlesh benlesh requested a review from a team as a code owner March 28, 2019 21:59
@ngbot ngbot bot added this to the needsTriage milestone Mar 28, 2019
mhevery
mhevery suggested changes Mar 29, 2019
View reviewed changes
packages/core/src/render3/instructions/instructions.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions/instructions.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions/instructions.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions/instructions.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions/instructions.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions/property_interpolate.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions/property_interpolate.ts Outdated Show resolved Hide resolved
packages/core/src/render3/instructions/property_interpolate.ts Outdated Show resolved Hide resolved
@benlesh
refactor(ivy): move property instruction
678535f 
- moves the property instruction to its own file
- moves shared functions that should not be public to the existing `shared.ts` file.
- adds the export of `property.ts` to `all.ts`
@benlesh
refactor(ivy): fix formatting issue with select comment
cd148b2
@benlesh
feat(ivy): add ΔpropertyInterpolate instructions
daf0fda 
- Adds the instructions
- Adds tests for all instructions
- Adds TODO to remove all tests when we are able to test this with TestBed after the compiler is updated
@benlesh
Copy link
Contributor Author

benlesh commented Apr 10, 2019

presubmit

@benlesh benlesh requested a review from mhevery April 10, 2019 20:29
@benlesh benlesh added the action: merge The PR is ready for merge by the caretaker label Apr 10, 2019
@IgorMinar IgorMinar closed this in 147a15a Apr 10, 2019
IgorMinar pushed a commit that referenced this pull request Apr 10, 2019
@benlesh @IgorMinar
refactor(ivy): fix formatting issue with select comment (#29576)
b71cd7b 
PR Close #29576
IgorMinar pushed a commit that referenced this pull request Apr 10, 2019
@benlesh @IgorMinar
feat(ivy): add ΔpropertyInterpolate instructions (#29576)
a80637e 
- Adds the instructions
- Adds tests for all instructions
- Adds TODO to remove all tests when we are able to test this with TestBed after the compiler is updated

PR Close #29576
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@benlesh @wKoza
refactor(ivy): move property instruction (angular#29576)
9b41b9d 
- moves the property instruction to its own file
- moves shared functions that should not be public to the existing `shared.ts` file.
- adds the export of `property.ts` to `all.ts`

PR Close angular#29576
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@benlesh @wKoza
refactor(ivy): fix formatting issue with select comment (angular#29576
0cd7f20 
)

PR Close angular#29576
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@benlesh @wKoza
feat(ivy): add ΔpropertyInterpolate instructions (angular#29576)
adbc9c2 
- Adds the instructions
- Adds tests for all instructions
- Adds TODO to remove all tests when we are able to test this with TestBed after the compiler is updated

PR Close angular#29576
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes feature Issue that requests a new feature risk: low target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benlesh @mhevery @googlebot