perf(ivy): avoid storing raw selectors in projectionDef #29578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
|
Introducing a flag would definitely make it more consistent, but I'm not sure whether it would help with processing since the |
mhevery
suggested changes
Apr 1, 2019
crisbeto
force-pushed
the
FW-955/ng-project-as
branch
6 times, most recently
from
c1a6635
to
e974d32
Compare
|
I've reworked it to use a marker for |
petebacondarwin
approved these changes
Apr 4, 2019
kara
requested changes
Apr 8, 2019
kara
added
action: cleanup
crisbeto
force-pushed
the
FW-955/ng-project-as
branch
from
e974d32
to
54213d7
Compare
crisbeto
added
action: review
|
Rebased and addressed the feedback @kara. |
crisbeto
force-pushed
the
FW-955/ng-project-as
branch
from
54213d7
to
5fa8f04
Compare
mhevery
approved these changes
Apr 9, 2019
mhevery
added
action: merge
kara
added
the
merge: caretaker note
|
merge assistance: global approval |
IgorMinar
added
the
action: cleanup
|
@crisbeto this PR now has a big conflict. can you please resolve it? thank you! |
Currently in Ivy we pass both the raw and parsed selectors to the projectionDef instruction, because the parsed selectors are used to match most nodes, whereas the raw ones are used to match against nodes with the ngProjectAs attribute. The raw selectors add a fair bit of code that won't be used in most cases, because ngProjectAs is somewhat rare. These changes rework the compiler not to output the raw selectors in the projectionDef, but to parse the selector in ngProjectAs and to store it on the TAttributes. The logic for matching has also been changed so that it matches the pre-parsed ngProjectAs selector against the list of projection selectors.
crisbeto
force-pushed
the
FW-955/ng-project-as
branch
2 times, most recently
from
43a90d0
to
c59c34e
Compare
crisbeto
force-pushed
the
FW-955/ng-project-as
branch
from
c59c34e
to
0400a3d
Compare
crisbeto
removed
the
action: cleanup
|
Conflicts have been resolved. |
|
@crisbeto thank you! ❤️ |
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
Currently in Ivy we pass both the raw and parsed selectors to the projectionDef instruction, because the parsed selectors are used to match most nodes, whereas the raw ones are used to match against nodes with the ngProjectAs attribute. The raw selectors add a fair bit of code that won't be used in most cases, because ngProjectAs is somewhat rare. These changes rework the compiler not to output the raw selectors in the projectionDef, but to parse the selector in ngProjectAs and to store it on the TAttributes. The logic for matching has also been changed so that it matches the pre-parsed ngProjectAs selector against the list of projection selectors. PR Close angular#29578
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Ivy we pass both the raw and parsed selectors to the
projectionDefinstruction, because the parsed selectors are used to match most nodes, whereas the raw ones are used to match against nodes with thengProjectAsattribute. The raw selectors add a fair bit of code that won't be used in most cases, becausengProjectAsis somewhat rare.These changes rework the compiler not to output the raw selectors in the
projectionDef, but to parse the selector inngProjectAsand to store it on theTAttributes. The logic for matching has also been changed so that it matches the pre-parsedngProjectAsselector against the list of projection selectors.