Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change error message #29594

Closed
wants to merge 1 commit into from
Closed

refactor: change error message #29594

wants to merge 1 commit into from

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented Mar 29, 2019 •
edited

Removes usage of whitelist from error messages, comments and test descriptions in ts_api_guardian

Related to #28529

@benlesh benlesh added area: build & ci Related the build and CI infrastructure of the project refactoring Issue that involves refactoring or code-cleanup target: patch This PR is targeted for the next patch release risk: low labels Mar 29, 2019
@benlesh benlesh requested a review from a team as a code owner March 29, 2019 18:21
@ngbot ngbot bot added this to the needsTriage milestone Mar 29, 2019
@benlesh benlesh added the action: merge The PR is ready for merge by the caretaker label Apr 1, 2019
gkalpak
gkalpak approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment. Also the issue referenced in commit message/PR description (#28539) seems unrelated 🤔 (You probably meant a different issue).

Other than that LGTM 👍

tools/ts-api-guardian/lib/serializer.ts Outdated Show resolved Hide resolved
@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Apr 1, 2019
@gkalpak
Copy link
Member

gkalpak commented Apr 1, 2019

Oh, also the commit message should be refactor: change error message (since tools/... is not part of packages/common).

@benlesh
refactor: change error message
554ea0a 
Removes usage of whitelist from error messages, comments and test descriptions in ts_api_guardian

Related to angular#28539
@benlesh benlesh added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 1, 2019
@gkalpak gkalpak changed the title refactor(common): Change error message refactor: change error message Apr 2, 2019
jasonaden pushed a commit that referenced this pull request Apr 2, 2019
@benlesh @jasonaden
refactor: change error message (#29594)
e2e0be4 
Removes usage of whitelist from error messages, comments and test descriptions in ts_api_guardian

Related to #28539

PR Close #29594
@jasonaden jasonaden closed this in 1c07061 Apr 2, 2019
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
@benlesh @DeveloperFromUkraine
refactor: change error message (angular#29594)
98b235e 
Removes usage of whitelist from error messages, comments and test descriptions in ts_api_guardian

Related to angular#28539

PR Close angular#29594
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@benlesh @wKoza
refactor: change error message (angular#29594)
deeafe4 
Removes usage of whitelist from error messages, comments and test descriptions in ts_api_guardian

Related to angular#28539

PR Close angular#29594
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes refactoring Issue that involves refactoring or code-cleanup risk: low target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benlesh @gkalpak @alexeagle @googlebot