test(docs-infra): add e2e test for the contributors page #29601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
action: merge
|
You can preview d01a6bf at https://pr29601-d01a6bf.ngbuilds.io/. |
Previously, if the shape of data in `contributors.json` was incorrect, there would be a runtime error (when trying to parse the data), which would result in a blank page. The likelihood for this happening is higher after angular#29553, where the shape of data changed. This commit adds some basic e2e tests that verify the page works as expected and there are contributors listed.
gkalpak
force-pushed
the
build-aio-contributors-checks
branch
from
d01a6bf
to
2230d5c
Compare
|
You can preview 2230d5c at https://pr29601-2230d5c.ngbuilds.io/. |
gkalpak
added
state: blocked
and removed
action: merge
petebacondarwin
approved these changes
Mar 30, 2019
gkalpak
added
action: merge
jasonaden
pushed a commit
that referenced
this pull request
Apr 1, 2019
jasonaden
pushed a commit
that referenced
this pull request
Apr 1, 2019
Previously, if the shape of data in `contributors.json` was incorrect, there would be a runtime error (when trying to parse the data), which would result in a blank page. The likelihood for this happening is higher after #29553, where the shape of data changed. This commit adds some basic e2e tests that verify the page works as expected and there are contributors listed. PR Close #29601
jasonaden
pushed a commit
that referenced
this pull request
Apr 1, 2019
Previously, if the shape of data in `contributors.json` was incorrect, there would be a runtime error (when trying to parse the data), which would result in a blank page. The likelihood for this happening is higher after #29553, where the shape of data changed. This commit adds some basic e2e tests that verify the page works as expected and there are contributors listed. PR Close #29601
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Apr 1, 2019
One of the tests introduced in angular#29601 is susceptible to a kind of WebDriver flake related to trying to click elements hidden behind fixed positioned elements. This commit works around the issue by clicking the elements directly using JavaScript (instead of `WebElement#click()`).
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
Previously, if the shape of data in `contributors.json` was incorrect, there would be a runtime error (when trying to parse the data), which would result in a blank page. The likelihood for this happening is higher after angular#29553, where the shape of data changed. This commit adds some basic e2e tests that verify the page works as expected and there are contributors listed. PR Close angular#29601
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…9641) One of the tests introduced in angular#29601 is susceptible to a kind of WebDriver flake related to trying to click elements hidden behind fixed positioned elements. This commit works around the issue by clicking the elements directly using JavaScript (instead of `WebElement#click()`). PR Close angular#29641
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the shape of data in
contributors.jsonwas incorrect, there would be a runtime error (when trying to parse the data), which would result in a blank page. The likelihood for this happening is higher after #29553, where the shape of data changed.This commit adds some basic e2e tests that verify the page works as expected and there are contributors listed.
(This PR also includes a commit to use a smaller image for @jbedard (since it was already available) 😁)