Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typos in getting-started #29665

Closed
wants to merge 1 commit into from
Closed

docs: fix typos in getting-started #29665

wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

PR #27684 introduced a new getting-started guide and a few typos slipped through the review.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@cexbrayat
docs: fix typos in getting-started
c6d6b4f 
PR angular#27684 introduced a new getting-started guide and a few typos slipped through the review.
@cexbrayat cexbrayat requested a review from a team as a code owner April 2, 2019 14:53
@brandonroberts brandonroberts self-assigned this Apr 2, 2019
@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR type: bug/fix labels Apr 2, 2019
@ngbot ngbot bot added this to the Backlog milestone Apr 2, 2019
@brandonroberts brandonroberts added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Apr 2, 2019
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Apr 2, 2019
@jasonaden jasonaden closed this in 9e4c0bd Apr 2, 2019
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
@cexbrayat @DeveloperFromUkraine
docs: fix typos in getting-started (angular#29665)
104e28d 
PR angular#27684 introduced a new getting-started guide and a few typos slipped through the review.

PR Close angular#29665
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@cexbrayat @wKoza
docs: fix typos in getting-started (angular#29665)
54e23c0 
PR angular#27684 introduced a new getting-started guide and a few typos slipped through the review.

PR Close angular#29665
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees

@brandonroberts brandonroberts

Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cexbrayat @brandonroberts @googlebot