Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add explanation on what lazy loading is #29667

Closed

Conversation

kapunahelewong
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #28547

What is the new behavior?

Added a paragraph about what lazy loading is.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kapunahelewong kapunahelewong requested a review from a team as a code owner April 2, 2019 15:50
@mary-poppins
Copy link

You can preview 2144e83 at https://pr29667-2144e83.ngbuilds.io/.

@ngbot ngbot bot added this to the needsTriage milestone Apr 2, 2019
@kapunahelewong kapunahelewong added target: patch This PR is targeted for the next patch release and removed comp: docs labels Apr 3, 2019
@ngbot ngbot bot removed this from the needsTriage milestone Apr 3, 2019
@jasonaden jasonaden added this to the needsTriage milestone Apr 4, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 6, 2019
@brandonroberts brandonroberts self-assigned this May 6, 2019
Copy link
Contributor

@DeborahK DeborahK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label May 6, 2019
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kara pushed a commit that referenced this pull request May 6, 2019
@kara kara closed this in 0926119 May 6, 2019
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@kapunahelewong kapunahelewong deleted the explain-lazy-loading branch June 20, 2019 18:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq3: high risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants