Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): DI module-level info fix #29756

Closed
wants to merge 1 commit into from
Closed

docs(core): DI module-level info fix #29756

wants to merge 1 commit into from

Conversation

renanmontebelo
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@renanmontebelo renanmontebelo requested a review from a team as a code owner April 7, 2019 19:44
@brandonroberts brandonroberts self-assigned this Apr 9, 2019
@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR type: bug/fix labels Apr 9, 2019
@ngbot ngbot bot modified the milestone: Backlog Apr 9, 2019
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime labels Apr 9, 2019
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good fixes and I made the first one in a PR that has since evolved into a larger rewrite of this guide (including this paragraph being largely rethought). @renanmontebelo check out where how it stands right now: Hierarchical Injectors updates in 28700.

Thank you for taking the time to fix this. 🌺
EDIT: Never mind my previous comments. LGTM, but you still might like to see that other PR. Comments are welcome!

IgorMinar pushed a commit that referenced this pull request Apr 9, 2019
@IgorMinar IgorMinar closed this in 4f0110e Apr 9, 2019
@renanmontebelo
Copy link
Contributor Author

These are good fixes and I made the first one in a PR that has since evolved into a larger rewrite of this guide (including this paragraph being largely rethought). @renanmontebelo check out where how it stands right now: Hierarchical Injectors updates in 28700.

Thank you for taking the time to fix this. 🌺
EDIT: Never mind my previous comments. LGTM, but you still might like to see that other PR. Comments are welcome!

Hi @kapunahelewong , thanks for your comments. I agree with you, this whole section deserves a good refactoring. As this PR was closed I'll chime in 28700. Thanks!

DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
@renanmontebelo renanmontebelo deleted the di_doc branch April 16, 2019 03:40
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants