New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(core): DI module-level info fix #29756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are good fixes and I made the first one in a PR that has since evolved into a larger rewrite of this guide (including this paragraph being largely rethought). @renanmontebelo check out where how it stands right now: Hierarchical Injectors updates in 28700.
Thank you for taking the time to fix this. 🌺
EDIT: Never mind my previous comments. LGTM, but you still might like to see that other PR. Comments are welcome!
Hi @kapunahelewong , thanks for your comments. I agree with you, this whole section deserves a good refactoring. As this PR was closed I'll chime in 28700. Thanks! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information