perf(ivy): coalesce handlers for events with the same name on the same element #29786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
force-pushed
the
listeners_coalescing_after_refactor
branch
3 times, most recently
from
93d1757
to
f1fda4b
Compare
pkozlowski-opensource
added
comp: ivy
target: major
mhevery
reviewed
Apr 9, 2019
kara
approved these changes
Apr 9, 2019
pkozlowski-opensource
force-pushed
the
listeners_coalescing_after_refactor
branch
from
f1fda4b
to
62ae12d
Compare
pkozlowski-opensource
force-pushed
the
listeners_coalescing_after_refactor
branch
from
62ae12d
to
5ebce66
Compare
kara
added
action: presubmit
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first, WIP version of a solution for https://hackmd.io/3cTDeLW0S-KdHtSR1dq7Qw
This PR has a minimal set of functionality to make handlers coalescing a reality. It doesn't include any perf-optimisations described in the design doc yet (tree-shaking and and runtime performance optimisations will be added in subsequent commits / PRs).
Still, opening this PR for an early review and performance testing.
Remaining work (to be done in separate PRs):
findExistingListener);