Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ivy): add injectable-pipe schematic #29847

Closed
wants to merge 2 commits into from
Closed

feat(ivy): add injectable-pipe schematic #29847

wants to merge 2 commits into from

Conversation

crisbeto
Copy link
Member

Adds a schematic that will annotate all Pipe classes with Injectable so that they can be injected.

This PR resolves FW-1228.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy labels Apr 11, 2019
@crisbeto crisbeto requested a review from a team as a code owner April 11, 2019 19:38
@ngbot ngbot bot added this to the needsTriage milestone Apr 11, 2019
@crisbeto crisbeto force-pushed the FW-1228/injectable-pipe-migration branch 2 times, most recently from 75b3b45 to b4c6a47 Compare April 11, 2019 19:50
@crisbeto crisbeto changed the title feat(ivy): add schematic to add injectable-pipe schematic feat(ivy): add injectable-pipe schematic Apr 11, 2019
devversion
devversion approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few minor nits.

packages/core/schematics/migrations.json Outdated Show resolved Hide resolved
packages/core/schematics/migrations/injectable-pipe/BUILD.bazel Outdated Show resolved Hide resolved
packages/core/schematics/migrations/injectable-pipe/google3/injectablePipeRule.ts Outdated Show resolved Hide resolved
packages/core/schematics/migrations/injectable-pipe/util.ts Show resolved Hide resolved
packages/core/schematics/utils/tslint/BUILD.bazel Outdated Show resolved Hide resolved
kara
kara approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once comments from @devversion are resolved

@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes labels Apr 11, 2019
@kara kara added target: major This PR is targeted for the next major release and removed cla: yes labels Apr 11, 2019
@alfaproject
Copy link
Contributor

Just wondering, but can't the Pipe decorator also have the Injectable decorator logic if it really is mandatory for Ivy anyway then it would be a 2 in 1 decorator

@kara
Copy link
Contributor

kara commented Apr 12, 2019

@alfaproject We considered that, but combining the decorators that way would force all future pipes to generate extra code for injection defs even if they aren't designed to be injected. If we keep them separate, pipes where injection doesn't make sense can save the bytes.

Also worth noting that this schematic is a first pass. If we have time, we want to limit the pipes we're decorating to just those that are provided or injected.

@crisbeto crisbeto force-pushed the FW-1228/injectable-pipe-migration branch from b4c6a47 to ab58233 Compare April 12, 2019 18:20
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 12, 2019
@crisbeto
Copy link
Member Author

The feedback has been addressed @devversion @kara.

@kara kara added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 12, 2019
@kara
Copy link
Contributor

kara commented Apr 12, 2019

presubmit

@kara kara removed the action: presubmit The PR is in need of a google3 presubmit label Apr 12, 2019
@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 12, 2019
@crisbeto crisbeto removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 12, 2019
@crisbeto crisbeto force-pushed the FW-1228/injectable-pipe-migration branch 2 times, most recently from bdcec57 to 795d6b1 Compare April 12, 2019 19:40
@crisbeto crisbeto added state: blocked and removed action: merge The PR is ready for merge by the caretaker labels Apr 15, 2019
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed state: blocked labels Apr 22, 2019
@kara
Copy link
Contributor

kara commented Apr 22, 2019

@crisbeto Can you rebase this?

@crisbeto
feat(ivy): add injectable-pipe schematic
a57cd29 
Adds a schematic that will annotate all `Pipe` classes with `Injectable` so that they can be injected.

This PR resolves FW-1228.
@crisbeto crisbeto force-pushed the FW-1228/injectable-pipe-migration branch from 795d6b1 to c9b96a7 Compare April 23, 2019 15:54
@crisbeto
Copy link
Member Author

Rebased.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker labels Apr 23, 2019
@crisbeto crisbeto force-pushed the FW-1228/injectable-pipe-migration branch from c9b96a7 to 53c0a40 Compare April 23, 2019 16:05
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Apr 23, 2019
@crisbeto crisbeto force-pushed the FW-1228/injectable-pipe-migration branch from 53c0a40 to c2ba55e Compare April 23, 2019 16:18
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 23, 2019
@benlesh benlesh closed this in d92fb25 Apr 23, 2019
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@crisbeto @BioPhoton
feat(ivy): add injectable-pipe schematic (angular#29847)
2b453d8 
Adds a schematic that will annotate all `Pipe` classes with `Injectable` so that they can be injected.

This PR resolves FW-1228.

PR Close angular#29847
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crisbeto @alfaproject @kara @devversion @googlebot