-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ivy): log errors instead of re-throwing them #29853
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
added
target: major
This PR is targeted for the next major release
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Apr 11, 2019
AndrewKushnir
approved these changes
Apr 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
alxhub
approved these changes
Apr 11, 2019
In order to be backwards compatible with View Engine, Ivy should log errors by default in the TestBed error handler rather than re-throwing them. Re-throwing the errors is a breaking change that causes issues with libraries like ngrx that have async behavior and custom error handling. This logging approach has issues (for both VE and Ivy) because it can allow tests to pass inappropriately if errors are thrown inside listeners. However, since re-throwing would be breaking and requires a larger redesign, we should wait until post-Ivy.
kara
added
action: merge
The PR is ready for merge by the caretaker
action: presubmit
The PR is in need of a google3 presubmit
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Apr 11, 2019
pkozlowski-opensource
approved these changes
Apr 12, 2019
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
In order to be backwards compatible with View Engine, Ivy should log errors by default in the TestBed error handler rather than re-throwing them. Re-throwing the errors is a breaking change that causes issues with libraries like ngrx that have async behavior and custom error handling. This logging approach has issues (for both VE and Ivy) because it can allow tests to pass inappropriately if errors are thrown inside listeners. However, since re-throwing would be breaking and requires a larger redesign, we should wait until post-Ivy. PR Close angular#29853
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be backwards compatible with View Engine, Ivy should log
errors by default in the TestBed error handler rather than re-throwing
them. Re-throwing the errors is a breaking change that causes issues with
libraries like ngrx that have async behavior and custom error handling.
This logging approach has issues (for both VE and Ivy) because it can allow
tests to pass inappropriately if errors are thrown inside listeners. However,
since re-throwing would be breaking and requires a larger redesign, we should
wait until post-Ivy.