-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: publish ts-api-guardian rule in the npm package #29977
Closed
alan-agius4
wants to merge
2
commits into
angular:master
from
alan-agius4:ts-api-guardian-bazel-rule
Closed
build: publish ts-api-guardian rule in the npm package #29977
alan-agius4
wants to merge
2
commits into
angular:master
from
alan-agius4:ts-api-guardian-bazel-rule
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
area: build & ci
Related the build and CI infrastructure of the project
target: major
This PR is targeted for the next major release
labels
Apr 18, 2019
alan-agius4
changed the title
build: published ts-api-guardian rule in the npm package
build: publish ts-api-guardian rule in the npm package
Apr 18, 2019
With this change downstream users will no longer need to build ts-api-guardian from source as now the bazel rule is available in the npm package. This can be used by installing ts-api-guardian as a devDependency and changing the load syntax from: ``` load("@angular//tools/ts-api-guardian:index.bzl", "ts_api_guardian_test") ``` to: ``` load("@npm_ts_api_guardian//:index.bzl", "ts_api_guardian_test") ``` **Note**: downstream users should also clean their `WORKSPACE` and remove the dependencies of angular workspace.
alexeagle
approved these changes
Apr 19, 2019
I assume you found a way to test it downstream |
Yeah I did, with the good old |
alexeagle
approved these changes
Apr 19, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
With this change downstream users will no longer need to build ts-api-guardian from source as now the bazel rule is available in the npm package. This can be used by installing ts-api-guardian as a devDependency and changing the load syntax from: ``` load("@angular//tools/ts-api-guardian:index.bzl", "ts_api_guardian_test") ``` to: ``` load("@npm_ts_api_guardian//:index.bzl", "ts_api_guardian_test") ``` **Note**: downstream users should also clean their `WORKSPACE` and remove the dependencies of angular workspace. PR Close angular#29977
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: build & ci
Related the build and CI infrastructure of the project
cla: yes
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change downstream users will no longer need to build ts-api-guardian from source as now the bazel rule is available in the npm package.
This can be used by installing ts-api-guardian as a devDependency and changing the load syntax from:
to:
Note: downstream users should also clean their
WORKSPACE
and remove the dependencies of angular workspace.