Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs-infra): upgrade cli command docs sources to 7e7a1aa5e #29987

Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Apr 19, 2019

Updating angular#master from cli-builds#master.

Relevant changes in commit range:

Modified

  • help/analytics.json
  • help/build.json
  • help/generate.json

Relevant changes in commit range since PR #29954:

Modified

  • help/generate.json

Closes #29954

@gkalpak gkalpak requested a review from a team as a code owner April 19, 2019 09:43
@gkalpak gkalpak added aio: preview comp: docs effort1: hours action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release risk: low feature Issue that requests a new feature labels Apr 19, 2019
@ngbot ngbot bot added this to the Backlog milestone Apr 19, 2019
@gkalpak gkalpak modified the milestones: Backlog, docs-infra-tooling Apr 19, 2019
@mary-poppins
Copy link

You can preview a1fb4d7 at https://pr29987-a1fb4d7.ngbuilds.io/.

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 19, 2019
@benlesh benlesh added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 19, 2019
@benlesh
Copy link
Contributor

benlesh commented Apr 19, 2019

@gkalpak looks like this just has a conflict to resolve.

Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).

##
Relevant changes in [commit range](angular/cli-builds@664990c...7e7a1aa):

**Modified**
- help/analytics.json
- help/build.json
- help/generate.json

##
Relevant changes in [commit range](angular/cli-builds@437e037...7e7a1aa) since PR angular#29954:

**Modified**
- help/generate.json

##
Closes angular#29954
@gkalpak gkalpak force-pushed the upgrade-cli-src--master--7e7a1aa5e branch from a1fb4d7 to 9817736 Compare April 19, 2019 18:42
@mary-poppins
Copy link

You can preview 9817736 at https://pr29987-9817736.ngbuilds.io/.

@gkalpak
Copy link
Member Author

gkalpak commented Apr 19, 2019

@benlesh: Resolved 🥅

@gkalpak gkalpak removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 19, 2019
@benlesh benlesh closed this in 2271f20 Apr 19, 2019
@gkalpak gkalpak deleted the upgrade-cli-src--master--7e7a1aa5e branch April 23, 2019 09:44
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
…ular#29987)

Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).

##
Relevant changes in [commit range](angular/cli-builds@664990c...7e7a1aa):

**Modified**
- help/analytics.json
- help/build.json
- help/generate.json

##
Relevant changes in [commit range](angular/cli-builds@437e037...7e7a1aa) since PR angular#29954:

**Modified**
- help/generate.json

##
Closes angular#29954

PR Close angular#29987
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours feature Issue that requests a new feature risk: low target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants