Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(language-service): Add tests for quickinfo and definition #29990

Closed
wants to merge 1 commit into from
Closed

test(language-service): Add tests for quickinfo and definition #29990

wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Apr 19, 2019 •
edited

quickinfo is used for hover tooltip.
definition is used for "Go to definition".

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release labels Apr 19, 2019
@kyliau kyliau requested a review from a team as a code owner April 19, 2019 16:08
@ngbot ngbot bot added this to the needsTriage milestone Apr 19, 2019
@kyliau kyliau force-pushed the nglangsvc branch 2 times, most recently from e27d2fe to 4779d0b Compare April 19, 2019 17:41
@kyliau kyliau changed the title test(language-service): Add tests for quickinfo and definitionAndBoundSpan test(language-service): Add tests for quickinfo and definition Apr 19, 2019
@kyliau kyliau requested a review from vikerman April 19, 2019 18:49
vikerman
vikerman approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@vikerman vikerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment to the PR/file about the change required to the test client

@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Apr 19, 2019
@kyliau
test(language-service): Add tests for quickinfo and definition
cc405dd 
`quickinfo` is used for hover tooltip.
`definition` is used for "Go to definition".
@benlesh benlesh added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 19, 2019
@kyliau kyliau removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 19, 2019
@kyliau
Copy link
Contributor Author

kyliau commented Apr 19, 2019

caretaker: this PR is good to go, thank you!

@benlesh benlesh closed this in 017bf0b Apr 20, 2019
@kyliau kyliau deleted the nglangsvc branch April 25, 2019 17:44
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@kyliau @BioPhoton
test(language-service): Add tests for quickinfo and definition (angul…
b6cd0d7 
…ar#29990)

`quickinfo` is used for hover tooltip.
`definition` is used for "Go to definition".

PR Close angular#29990
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vikerman vikerman vikerman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyliau @vikerman @benlesh @googlebot