Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate dartanalyzer into build #2

Closed
mhevery opened this issue Sep 23, 2014 · 1 comment
Closed

Integrate dartanalyzer into build #2

mhevery opened this issue Sep 23, 2014 · 1 comment

Comments

@mhevery
Copy link
Contributor

mhevery commented Sep 23, 2014

this implies we need angular.dart file which looks something like this:

library angular.dom.main;

export "annotations/directive.dart";
export "annotations/component.dart";
export "annotations/property.dart";
export "annotations/template.dart";
export "annotations/event.dart";
export "directive_injector/annotations.dart";
export "directive_injector/directive_injector.dart";
export "directive_injector/query.dart";
export "view/view.dart";
export "view/view_ref.dart";
export "view/view_factory.dart";
export "view/view_port.dart";
export "view/view_port_ref.dart";

Don't generate that, but we need something like this as public API.
@tbosch tbosch closed this as completed in 100d662 Sep 26, 2014
@mhevery mhevery mentioned this issue Oct 31, 2014
Closed
@kzhdev kzhdev mentioned this issue Jun 13, 2015
Closed
This was referenced Jun 18, 2015
Closed
Closed
@dsebastien dsebastien mentioned this issue Jul 2, 2015
Closed
@mhevery mhevery mentioned this issue Jul 7, 2015
Closed
@avoivo avoivo mentioned this issue Jul 31, 2015
Closed
@yjbanov yjbanov mentioned this issue Aug 1, 2015
Closed
Closed
goderbauer added a commit to goderbauer/angular that referenced this issue Aug 7, 2015
@goderbauer
fix(testability): fix type error in getAllAngularTestability (dart)
f894d08 
This fixes the following type error that is thrown when calling getAllAngularTestability() while running Dartium in checked mode:

type 'MappedListIterable' is not a subtype of type 'List<PublicTestability>' of 'publicTestabilities'.
#0      GetTestability.addToWindow.<anonymous closure> (package:angular2/src/core/testability/get_testability.dart:92:12)
#1      Function._apply (dart:core-patch/function_patch.dart:7)
angular#2      Function.apply (dart:core-patch/function_patch.dart:28)
angular#3      __invokeFn (package:angular2/src/core/testability/get_testability.dart:26:26)
angular#4      _jsFunction.<anonymous closure> (package:angular2/src/core/testability/get_testability.dart:15:12)
This was referenced Aug 7, 2015
Closed
Closed
@vikerman vikerman mentioned this issue Aug 26, 2015
Closed
@vikerman vikerman mentioned this issue Sep 5, 2015
Closed
@wardbell wardbell mentioned this issue Sep 7, 2015
Closed
@mhevery mhevery mentioned this issue Oct 6, 2015
Closed
@brandonroberts brandonroberts mentioned this issue Nov 15, 2015
Closed
@blwill blwill mentioned this issue Jan 11, 2016
Closed
@alexeagle alexeagle mentioned this issue Feb 11, 2016
Closed
@noxan noxan mentioned this issue Feb 17, 2016
Closed
mhevery referenced this issue in mhevery/angular Feb 18, 2016
@mhevery
chore: noImplicitAny fixes #2
3e8d9b3
mhevery referenced this issue in mhevery/angular Feb 18, 2016
@mhevery
chore: noImplicitAny fixes #2
c83724b
mhevery referenced this issue in mhevery/angular Feb 18, 2016
@mhevery
chore: noImplicitAny fixes #2
b665d71
mhevery referenced this issue in mhevery/angular Feb 18, 2016
@mhevery
chore: noImplicitAny fixes #2
1b76eb5
This was referenced Mar 3, 2016
Closed
Closed
@alexeagle alexeagle mentioned this issue May 9, 2016
Closed
6 tasks
@brandonroberts brandonroberts mentioned this issue Aug 23, 2016
Closed
ottonascarella pushed a commit to ottonascarella/angular that referenced this issue Feb 20, 2018
# This is a combination of 4 commits.
71e0f0a 
# This is the 1st commit message:

fix(common): inconsistency on TitleCasePipe

TitleCasePipe was not behaving as expected with non-ascii characters.

# This is the commit message angular#2:

refactor(common): lint errors

# This is the commit message angular#3:

feat(common): more tests for TitleCasePipe

Copied tests from angular#20123, just to make sure fix covers all needs.

# This is the commit message angular#4:

refactor(common): fix linting errors
@jenniferfell jenniferfell mentioned this issue Mar 1, 2018
Closed
@kara kara mentioned this issue May 4, 2018
Closed
@gregmagolan gregmagolan mentioned this issue May 28, 2018
Closed
3 tasks
jbogarthyde added a commit to jbogarthyde/angular that referenced this issue Jul 12, 2018
@jbogarthyde
# This is a combination of 3 commits.
3790bd6 
# This is the 1st commit message:

docs: add api doc to commonly queried elements

# The commit message angular#2 will be skipped:

# fixup! docs: add api doc to commonly queried elements

# The commit message angular#3 will be skipped:

# fixup! docs: add api doc to commonly queried elements
@AbakumovAlexandr AbakumovAlexandr mentioned this issue Aug 8, 2018
Open
@dirkluijk dirkluijk mentioned this issue Aug 31, 2018
Closed
@IgorMinar IgorMinar mentioned this issue Sep 4, 2018
Closed
@jenniferfell jenniferfell mentioned this issue Oct 8, 2018
Closed
3 tasks
lucasklaassen added a commit to lucasklaassen/angular that referenced this issue Oct 30, 2018
@lucasklaassen
Theory angular#2
fed9d6b
@Airblader Airblader mentioned this issue Nov 20, 2018
Closed
@alxhub alxhub mentioned this issue Nov 26, 2018
Closed
alxhub referenced this issue in alxhub/angular Dec 5, 2018
@alxhub
fix(ivy): generate empty ngfactory files if needed
f6f134d 
Previously the ngfactory shim generator in ngtsc would always write two
imports in the factory file shims:

1) an import to @angular/core
2) an import to the base file

If the base file has no exports, import #2 would be empty. This turns out
to cause issues downstream.

This commit changes the generated shim so if there are no exports in the
base file, the generated shim is empty too.
alxhub referenced this issue in alxhub/angular Dec 5, 2018
@alxhub
fix(ivy): generate empty ngfactory files if needed
8c94cd6 
Previously the ngfactory shim generator in ngtsc would always write two
imports in the factory file shims:

1) an import to @angular/core
2) an import to the base file

If the base file has no exports, import #2 would be empty. This turns out
to cause issues downstream.

This commit changes the generated shim so if there are no exports in the
base file, the generated shim is empty too.
IgorMinar referenced this issue in alxhub/angular Dec 5, 2018
@alxhub @IgorMinar
fix(ivy): generate empty ngfactory files if needed
024516e 
Previously the ngfactory shim generator in ngtsc would always write two
imports in the factory file shims:

1) an import to @angular/core
2) an import to the base file

If the base file has no exports, import #2 would be empty. This turns out
to cause issues downstream.

This commit changes the generated shim so if there are no exports in the
base file, the generated shim is empty too.
IgorMinar pushed a commit that referenced this issue Dec 5, 2018
@alxhub @IgorMinar
fix(ivy): generate empty ngfactory files if needed (#27470)
345bdd3 
Previously the ngfactory shim generator in ngtsc would always write two
imports in the factory file shims:

1) an import to @angular/core
2) an import to the base file

If the base file has no exports, import #2 would be empty. This turns out
to cause issues downstream.

This commit changes the generated shim so if there are no exports in the
base file, the generated shim is empty too.

PR Close #27470
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this issue Jan 3, 2019
@alxhub @FrederikSchlemmer
fix(ivy): generate empty ngfactory files if needed (angular#27470)
89b1ddb 
Previously the ngfactory shim generator in ngtsc would always write two
imports in the factory file shims:

1) an import to @angular/core
2) an import to the base file

If the base file has no exports, import angular#2 would be empty. This turns out
to cause issues downstream.

This commit changes the generated shim so if there are no exports in the
base file, the generated shim is empty too.

PR Close angular#27470
ngfelixl pushed a commit to ngfelixl/angular that referenced this issue Jan 28, 2019
@alxhub @ngfelixl
fix(ivy): generate empty ngfactory files if needed (angular#27470)
6edfa76 
Previously the ngfactory shim generator in ngtsc would always write two
imports in the factory file shims:

1) an import to @angular/core
2) an import to the base file

If the base file has no exports, import angular#2 would be empty. This turns out
to cause issues downstream.

This commit changes the generated shim so if there are no exports in the
base file, the generated shim is empty too.

PR Close angular#27470
@alxhub alxhub mentioned this issue Jan 29, 2019
Closed
@DeborahK DeborahK mentioned this issue Feb 7, 2019
Closed
14 tasks
@alyssamichelle alyssamichelle mentioned this issue Mar 1, 2019
Closed
14 tasks
@alxhub alxhub mentioned this issue Jun 13, 2019
Closed
14 tasks
@kara kara mentioned this issue Jul 10, 2019
Closed
@ronakpandya7 ronakpandya7 mentioned this issue Aug 8, 2019
Closed
@JonWallsten JonWallsten mentioned this issue Aug 8, 2019
Closed
@JohannesHoppe JohannesHoppe mentioned this issue Aug 29, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhevery @tbosch