build: unable to accept new symbol-extractor golden on windows #30127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
area: build & ci
gkalpak
approved these changes
Apr 25, 2019
Currently when working on Windows, it's not possible to accept a new golden for a `symbol-extractor` Bazel test. This is because the generated executable output from the `nodejs_binary` rule (without a macro) misses a Windows executable wrapper that sets up the proper environment variables for the runfiles. Causing the following failure on Windows: ``` >>>> FAIL: RUNFILES environment variable is not set. <<<< ```
devversion
force-pushed
the
fix/symbol-extractor-windows-accept-golden
branch
from
2ea2529
to
25a0b3e
Compare
devversion
added
action: merge
AndrewKushnir
added
target: major
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 26, 2019
Currently when working on Windows, it's not possible to accept a new golden for a `symbol-extractor` Bazel test. This is because the generated executable output from the `nodejs_binary` rule (without a macro) misses a Windows executable wrapper that sets up the proper environment variables for the runfiles. Causing the following failure on Windows: ``` >>>> FAIL: RUNFILES environment variable is not set. <<<< ``` PR Close #30127
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ar#30127) Currently when working on Windows, it's not possible to accept a new golden for a `symbol-extractor` Bazel test. This is because the generated executable output from the `nodejs_binary` rule (without a macro) misses a Windows executable wrapper that sets up the proper environment variables for the runfiles. Causing the following failure on Windows: ``` >>>> FAIL: RUNFILES environment variable is not set. <<<< ``` PR Close angular#30127
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when working on Windows, it's not possibly to accept a new
golden for a
symbol-extractorBazel test. This is because the generatedexecutable output from the
nodejs_binaryrule (without a macro) missesa Windows executable wrapper that sets up the proper environment
variables for the runfiles. Causing the following failure on Windows: