Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): prevent binding off-by-one errors in property bindings #30129

Closed
wants to merge 1 commit into from
Closed

fix(ivy): prevent binding off-by-one errors in property bindings #30129

wants to merge 1 commit into from

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented Apr 25, 2019

  • Extracts and documents code that will be common to interpolation instructions
  • Ensures that binding indices are updated at the proper time during compilation
  • Adds additional tests

Related #30011

NOTE: This is a direct branch off of #30011, just exlcuding the addition of textInterpolate instructions.

@benlesh benlesh requested review from a team as code owners April 25, 2019 20:46
@benlesh benlesh added area: core Issues related to the framework runtime comp: ivy target: major This PR is targeted for the next major release type: bug/fix labels Apr 25, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 25, 2019
@benlesh benlesh requested a review from kara April 25, 2019 21:28
kara
kara approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh
fix(ivy): property bindings use correct indices
ad6cc9a 
- Extracts and documents code that will be common to interpolation instructions
- Ensures that binding indices are updated at the proper time during compilation
- Adds additional tests

Related angular#30011
@benlesh benlesh added the action: merge The PR is ready for merge by the caretaker label Apr 25, 2019
@kara kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 25, 2019
@kara
Copy link
Contributor

kara commented Apr 25, 2019

merge-assistance: global

@kara kara added action: presubmit The PR is in need of a google3 presubmit target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release action: presubmit The PR is in need of a google3 presubmit labels Apr 25, 2019
@IgorMinar IgorMinar modified the milestones: needsTriage, version 8 Apr 26, 2019
AndrewKushnir pushed a commit that referenced this pull request Apr 26, 2019
@benlesh @AndrewKushnir
fix(ivy): property bindings use correct indices (#30129)
a50bfe5 
- Extracts and documents code that will be common to interpolation instructions
- Ensures that binding indices are updated at the proper time during compilation
- Adds additional tests

Related #30011

PR Close #30129
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@benlesh @BioPhoton
fix(ivy): property bindings use correct indices (angular#30129)
f9a2326 
- Extracts and documents code that will be common to interpolation instructions
- Ensures that binding indices are updated at the proper time during compilation
- Adds additional tests

Related angular#30011

PR Close angular#30129
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
version 8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benlesh @kara @IgorMinar @googlebot