Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ivy): undeprecate inject #30132

Closed
wants to merge 4 commits into from
Closed

refactor(ivy): undeprecate inject #30132

wants to merge 4 commits into from

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented Apr 25, 2019

Per offline discussion, inject is already an API that is seeing limited use. We are going to undeprecate it for now.

@benlesh benlesh requested a review from a team as a code owner April 25, 2019 23:32
@benlesh benlesh requested a review from mhevery April 25, 2019 23:32
@benlesh benlesh added comp: ivy target: major This PR is targeted for the next major release risk: low refactoring Issue that involves refactoring or code-cleanup and removed cla: yes labels Apr 25, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 25, 2019
@benlesh benlesh requested a review from kara April 25, 2019 23:45
kara
kara approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh added the action: merge The PR is ready for merge by the caretaker label Apr 25, 2019
@benlesh benlesh requested a review from a team as a code owner April 26, 2019 00:12
@benlesh
Copy link
Contributor Author

benlesh commented Apr 26, 2019

presubmit

@ericmartinezr ericmartinezr mentioned this pull request Apr 26, 2019
Closed
@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Apr 26, 2019
AndrewKushnir pushed a commit that referenced this pull request Apr 26, 2019
@benlesh @AndrewKushnir
refactor(ivy): undeprecate inject (#30132)
8dd9192 
PR Close #30132
@trotyl trotyl mentioned this pull request May 11, 2019
Closed
14 tasks
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@benlesh @BioPhoton
refactor(ivy): undeprecate inject (angular#30132)
ff27820 
PR Close angular#30132
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

@mhevery mhevery mhevery approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup risk: low target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@benlesh @mhevery @IgorMinar @kara @googlebot @AndrewKushnir