refactor(core): static-query migrations fails if options cannot be transformed #30178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansformed Currently the `static-query` migrations fails at the final step of updating a query when the query already specifies options which cannot be transformed easily. e.g. the options are computed through a function call: `@ViewChild(..., getQueryOpts());` or `@ViewChild(..., myOptionsVar)`. In these cases we technically could add additionally logic to update the query options, but given that this is an edge-case and it's potentially over-engineering the migration schematic, we just always add a TODO for the timing and print out the determined query timing in the console. The developer in that case just needs to manually update the logic for the query options to contain the printed query timing. Potentially related to: angular/angular-cli#14298
devversion
added
action: review
JoostK
approved these changes
Apr 28, 2019
kara
added
action: presubmit
kara
added
action: merge
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 29, 2019
…ansformed (#30178) Currently the `static-query` migrations fails at the final step of updating a query when the query already specifies options which cannot be transformed easily. e.g. the options are computed through a function call: `@ViewChild(..., getQueryOpts());` or `@ViewChild(..., myOptionsVar)`. In these cases we technically could add additionally logic to update the query options, but given that this is an edge-case and it's potentially over-engineering the migration schematic, we just always add a TODO for the timing and print out the determined query timing in the console. The developer in that case just needs to manually update the logic for the query options to contain the printed query timing. Potentially related to: angular/angular-cli#14298 PR Close #30178
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ansformed (angular#30178) Currently the `static-query` migrations fails at the final step of updating a query when the query already specifies options which cannot be transformed easily. e.g. the options are computed through a function call: `@ViewChild(..., getQueryOpts());` or `@ViewChild(..., myOptionsVar)`. In these cases we technically could add additionally logic to update the query options, but given that this is an edge-case and it's potentially over-engineering the migration schematic, we just always add a TODO for the timing and print out the determined query timing in the console. The developer in that case just needs to manually update the logic for the query options to contain the printed query timing. Potentially related to: angular/angular-cli#14298 PR Close angular#30178
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
static-querymigrations fails at the final step ofupdating a query when the query already specifies options which
cannot be transformed easily. e.g. the options are computed through
a function call:
@ViewChild(..., getQueryOpts());or through an identifierthat refers to the options literal:
@ViewChild(..., myOptionsVar).In these cases we technically could add additionally logic to update
the query options, but given that this is an edge-case and it's
potentially over-engineering the migration schematic, we just
always add a TODO for the timing and print out the determined
query timing in the console. The developer in that case just needs
to manually update the logic for the query options to contain the
printed query timing.
Related to: angular/angular-cli#14298