Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ivy): store views directly on LContainer #30179

Closed
wants to merge 1 commit into from
Closed

perf(ivy): store views directly on LContainer #30179

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Stores the views that are part of a container directly on the LContainer, rather than maintaining a dedicated sub-array.

This PR resolves FW-1288.

@crisbeto crisbeto force-pushed the FW-1288/container-refactor-1 branch 7 times, most recently from bd77336 to 04f8af9 Compare April 29, 2019 15:30
@crisbeto crisbeto added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 29, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 29, 2019
@crisbeto crisbeto marked this pull request as ready for review April 29, 2019 15:46
@crisbeto crisbeto requested a review from a team as a code owner April 29, 2019 15:46
kara
kara approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

packages/core/src/render3/view_engine_compatibility.ts Outdated Show resolved Hide resolved
@kara kara added action: presubmit The PR is in need of a google3 presubmit target: major This PR is targeted for the next major release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 29, 2019
@kara
Copy link
Contributor

kara commented Apr 29, 2019 •
edited

presubmit

Ivy presubmit

@crisbeto
perf(ivy): store views directly on LContainer
35a462d 
Stores the views that are part of a container directly on the `LContainer`, rather than maintaining a dedicated sub-array.

This PR resolves FW-1288.
@crisbeto crisbeto force-pushed the FW-1288/container-refactor-1 branch from 04f8af9 to 35a462d Compare April 29, 2019 19:17
@crisbeto crisbeto removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 29, 2019
@crisbeto crisbeto removed their assignment Apr 29, 2019
@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Apr 29, 2019
@kara kara closed this in ad94e02 Apr 30, 2019
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@crisbeto @BioPhoton
perf(ivy): store views directly on LContainer (angular#30179)
81b1b26 
Stores the views that are part of a container directly on the `LContainer`, rather than maintaining a dedicated sub-array.

This PR resolves FW-1288.

PR Close angular#30179
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @kara @googlebot