test(core): run schematic tests with public migration collection #30198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
action: review
devversion
changed the title
devversion
force-pushed
the
test/core-run-schematic-tests-against-public-migration-collection
branch
from
cf3762d
to
491afff
Compare
572b549 changed how the schematic tests are executed. Tests no longer use the schematic collection that is also used by the CLI `ng update` command and therefore the migration collection could technically be invalid. In order to ensure that the public migration collection is guaranteed to work and to avoid duplication within two schematic collections, the changes are partially reverted and only the disabled `injectable-pipe` schematic has its own collection.
devversion
force-pushed
the
test/core-run-schematic-tests-against-public-migration-collection
branch
from
491afff
to
61a1054
Compare
kara
added
action: merge
alxhub
pushed a commit
that referenced
this pull request
May 8, 2019
) 572b549 changed how the schematic tests are executed. Tests no longer use the schematic collection that is also used by the CLI `ng update` command and therefore the migration collection could technically be invalid. In order to ensure that the public migration collection is guaranteed to work and to avoid duplication within two schematic collections, the changes are partially reverted and only the disabled `injectable-pipe` schematic has its own collection. PR Close #30198
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ular#30198) 572b549 changed how the schematic tests are executed. Tests no longer use the schematic collection that is also used by the CLI `ng update` command and therefore the migration collection could technically be invalid. In order to ensure that the public migration collection is guaranteed to work and to avoid duplication within two schematic collections, the changes are partially reverted and only the disabled `injectable-pipe` schematic has its own collection. PR Close angular#30198
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
572b549 changed how the schematic tests are executed. Tests no
longer use the schematic collection that is also used by the CLI
ng updatecommand and therefore the migration collection couldtechnically be invalid.
In order to ensure that the public migration collection is guaranteed
to work and to avoid duplication within two schematic collections, the
changes are partially reverted and only the disabled
injectable-pipeschematic has its own collection.