New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix naming miss and improve with anchor reference in router guide #30225
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
You can preview 8edb5ae at https://pr30225-8edb5ae.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add in router guide
to git commit message
aio/content/guide/router.md
Outdated
@@ -2677,7 +2677,8 @@ display the `Crisis Center Home` and `Crisis Detail` route components. | |||
|
|||
The `Crisis Detail` route is a child of the `Crisis List`. The router [reuses components](#reuse) | |||
by default, so the `Crisis Detail` component will be re-used as you select different crises. | |||
In contrast, back in the `Hero Detail` route, the component was recreated each time you selected a different hero. | |||
In contrast, back in the `Hero Detail` route, [the component was recreated](#snapshot-the-no-observable-alternative) | |||
each time you selected a different hero by visiting the list component previously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each time you selected a different hero by visiting the list component previously. | |
each time you selected a different hero from the list of heroes. |
You can preview dd8c5df at https://pr30225-dd8c5df.ngbuilds.io/. |
Signed-off-by: Richard Lea <chigix@zoho.com>
dd8c5df
to
ecb5a03
Compare
You can preview ecb5a03 at https://pr30225-ecb5a03.ngbuilds.io/. |
…ngular#30225) Signed-off-by: Richard Lea <chigix@zoho.com> PR Close angular#30225
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Signed-off-by: Richard Lea chigix@zoho.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Only a few tweak in documentation friendlyness without any relation to feature definition.
What is the new behavior?
Does this PR introduce a breaking change?
Other information