Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix naming miss and improve with anchor reference in router guide #30225

Closed
wants to merge 1 commit into from

Conversation

chigix
Copy link
Contributor

@chigix chigix commented May 1, 2019

Signed-off-by: Richard Lea chigix@zoho.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Only a few tweak in documentation friendlyness without any relation to feature definition.

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@chigix chigix requested a review from a team as a code owner May 1, 2019 12:26
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@chigix
Copy link
Contributor Author

chigix commented May 1, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mary-poppins
Copy link

You can preview 8edb5ae at https://pr30225-8edb5ae.ngbuilds.io/.

@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR refactoring Issue that involves refactoring or code-cleanup labels May 6, 2019
@ngbot ngbot bot added this to the Backlog milestone May 6, 2019
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in router guide to git commit message

@@ -2677,7 +2677,8 @@ display the `Crisis Center Home` and `Crisis Detail` route components.

The `Crisis Detail` route is a child of the `Crisis List`. The router [reuses components](#reuse)
by default, so the `Crisis Detail` component will be re-used as you select different crises.
In contrast, back in the `Hero Detail` route, the component was recreated each time you selected a different hero.
In contrast, back in the `Hero Detail` route, [the component was recreated](#snapshot-the-no-observable-alternative)
each time you selected a different hero by visiting the list component previously.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
each time you selected a different hero by visiting the list component previously.
each time you selected a different hero from the list of heroes.

@brandonroberts brandonroberts added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 6, 2019
@mary-poppins
Copy link

You can preview dd8c5df at https://pr30225-dd8c5df.ngbuilds.io/.

Signed-off-by: Richard Lea <chigix@zoho.com>
@brandonroberts brandonroberts removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 6, 2019
@mary-poppins
Copy link

You can preview ecb5a03 at https://pr30225-ecb5a03.ngbuilds.io/.

@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label May 6, 2019
@brandonroberts brandonroberts changed the title docs: fix naming miss and improve with anchor reference docs: fix naming miss and improve with anchor reference in router guide May 6, 2019
@kara kara closed this in d6538eb May 6, 2019
kara pushed a commit that referenced this pull request May 6, 2019
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours refactoring Issue that involves refactoring or code-cleanup risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants