fix(ivy): evaluate external declaration usages as dynamic #30247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ngtsc would fail to evaluate expressions that access properties from e.g. the `window` object. This resulted in hard to debug error messages as no indication on where the problem originated was present in the output. This commit cleans up the handling of unknown property accesses, such that evaluating such expressions no longer fail but instead result in a `DynamicValue`. Fixes angular#30226
JoostK
added
target: major
alxhub
approved these changes
May 16, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
) Previously, ngtsc would fail to evaluate expressions that access properties from e.g. the `window` object. This resulted in hard to debug error messages as no indication on where the problem originated was present in the output. This commit cleans up the handling of unknown property accesses, such that evaluating such expressions no longer fail but instead result in a `DynamicValue`. Fixes angular#30226 PR Close angular#30247
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ngtsc would fail to evaluate expressions that access properties
from e.g. the
windowobject. This resulted in hard to debug error messagesas no indication on where the problem originated was present in the output.
This commit cleans up the handling of unknown property accesses, such that
evaluating such expressions no longer fail but instead result in a
DynamicValue.Fixes #30226