Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade zone.js to 0.9.1 #30260

Closed
wants to merge 1 commit into from
Closed

build: upgrade zone.js to 0.9.1 #30260

wants to merge 1 commit into from

Conversation

JiaLiPassion
Copy link
Contributor

Close #30203

resolves the issue that zone-legacy XHR issue

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #30203

What is the new behavior?

SEO mobile friendly test should be success without XHR error.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@JiaLiPassion
build: upgrade zone.js to 0.9.1
3e8992e 
Close 30203

resolves the issue that zone-legacy XHR issue
@JiaLiPassion JiaLiPassion requested review from a team as code owners May 3, 2019 20:19
@petebacondarwin petebacondarwin added target: patch This PR is targeted for the next patch release comp: docs-infra type: bug/fix labels May 4, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 4, 2019
@petebacondarwin petebacondarwin added the area: core Issues related to the framework runtime label May 4, 2019
@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label May 10, 2019
@alxhub alxhub closed this in 5ab809d May 10, 2019
alxhub pushed a commit that referenced this pull request May 10, 2019
@JiaLiPassion @alxhub
build: upgrade zone.js to 0.9.1 (#30260)
14c0017 
Close 30203

resolves the issue that zone-legacy XHR issue

PR Close #30260
@filipesilva filipesilva mentioned this pull request May 16, 2019
Closed
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@JiaLiPassion @BioPhoton
build: upgrade zone.js to 0.9.1 (angular#30260)
71a18f6 
Close 30203

resolves the issue that zone-legacy XHR issue

PR Close angular#30260
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@mhevery mhevery mhevery approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

Verify that SEO works well with differential loading
5 participants
@JiaLiPassion @petebacondarwin @mhevery @gkalpak @googlebot