Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): use TestBed for render3 component tests #30282

Closed
wants to merge 1 commit into from
Closed

test(ivy): use TestBed for render3 component tests #30282

wants to merge 1 commit into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented May 6, 2019 •
edited

I couldn't move all the tests related to renderComponent or ɵɵcontainer to TestBed unfortunately

@kara kara added the comp: ivy label May 6, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 6, 2019
@ocombe ocombe force-pushed the refactor/ivy/testbed-component-spec branch from 6cce011 to 64ea98f Compare May 9, 2019 13:18
@ocombe ocombe added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release and removed state: WIP labels May 9, 2019
@ocombe ocombe marked this pull request as ready for review May 9, 2019 13:20
@ocombe ocombe requested a review from a team as a code owner May 9, 2019 13:20
@ocombe ocombe force-pushed the refactor/ivy/testbed-component-spec branch 3 times, most recently from 2e0c149 to d4bc35c Compare May 9, 2019 14:46
@ocombe ocombe force-pushed the refactor/ivy/testbed-component-spec branch from d4bc35c to 6f12932 Compare May 9, 2019 15:02
kara
kara approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels May 10, 2019
alxhub pushed a commit that referenced this pull request May 10, 2019
@ocombe @alxhub
test(ivy): use TestBed for render3 component tests (#30282)
dbe845e 
PR Close #30282
@alxhub alxhub closed this in 24e172d May 10, 2019
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@ocombe @BioPhoton
test(ivy): use TestBed for render3 component tests (angular#30282)
dca50f9 
PR Close angular#30282
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocombe @kara @googlebot