Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@angular/animations] sequence non-intuitively/erroneously merges non-animated query() calls into single initial call #30361

Open
MagnusBrzenk opened this issue May 9, 2019 · 0 comments
Labels
area: animations freq1: low P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Milestone

Comments

@MagnusBrzenk
Copy link

馃悶 bug report

Affected Package

The issue is caused by package @angular/....

This is a problem with @angular/animations

Description

A clear and concise description of the problem...

I'm trying to create a complex angular animation with the sequence([]) function. What I am trying to achieve requires carefully setting various CSS properties on different elements in a well-defined series of events.

My efforts are being messed up because sequence([]) seems to combine individual query() steps that lack an animate() function into ONE query() call. So a sequence that looks like this:

sequence([
    query('.my-class', [
        style({
            display: 'none'
        })   
    ]),
    // ...
    // 1. Various other animated steps
    // ...
    query('.my-class', [
        style({
            display: 'block'
        })   
    ]),
    // ...
    // 2. Various other animated steps
    // ...
])

... ends up acting like this:

sequence([
    query('.my-class', [
        style({
            display: 'none',
            display: 'block'
        })   
    ]),
    // ...
    // 1. Various other animated steps
    // ...
    // ...
    // 2. Various other animated steps
    // ...
])

馃敩 Minimal Reproduction

https://stackblitz.com/...

The code I've been using to reach this conclusion can be seen in this file within the ['010-animationsContinued' branch].

The salient animation is triggered on any route change (e.g. clicking between 'data' and 'about' in the toolbar).

Note: this might be related to #27577, but I find this undesirable merging to occur not just with the display property, but others as well (e.g. position)

@ngbot ngbot bot added this to the needsTriage milestone May 9, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 28, 2019
@jelbourn jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed severity3: broken labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: animations freq1: low P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Development

No branches or pull requests

4 participants